Skip to content

feat: resolve css variables #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Conversation

paviad
Copy link

@paviad paviad commented Dec 14, 2024

Current style sheet logic ignores CSS variables, and can break when parsing them.

This PR properly resolves CSS variables.

@vitali-pr
Copy link
Contributor

Hi @paviad, thank you for your contribution!

Would you mind signing the Contributor License Agreement and send back to us? The details are available at https://itextpdf.com/en/how-buy/legal/itext-contributor-license-agreement - it's required in order to merge the PR.

@paviad
Copy link
Author

paviad commented Feb 18, 2025

Signed, scanned and sent.

@denighte
Copy link

Hi @paviad, thank you very much for your idea and contribution, as I specified on your pull request in itext-core we had to fix it differently.

@denighte denighte closed this Mar 27, 2025
@paviad
Copy link
Author

paviad commented Mar 27, 2025

Can you provide a link to the comment? I can't find it. Thanks!

@denighte
Copy link

denighte commented Mar 27, 2025

Can you provide a link to the comment? I can't find it. Thanks!

Oh, I actually posted in html2pdf repository instead, and this comment should have been in html2pdf, here is the link:
itext/itext-pdfhtml-dotnet#2 (comment)
Do note that the commit hash I posted there is actually for this repository, and in html2pdf there is only a single line change apart from tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants