Pr test 1 #1
Open
Pr test 1 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivankelly
reviewed
Nov 2, 2017
| private final OpStatsLogger opLogger; | ||
| private final OpStatsLogger timeoutOpLogger; | ||
| protected final Timeout timeout; | ||
| private final String operationName; |
| } | ||
|
|
||
| protected void doAsyncAddEntry(final PendingAddOp op, final ByteBuf data, final AddCallback cb, final Object ctx) { | ||
| protected void doAsyncAddEntry(final PendingAddOp op) { | ||
| if (throttler != null) { |
Improvements in maven configuration in order to speed up development Author: Enrico Olivelli <[email protected]> Reviewers: Ivan Kelly <[email protected]> This closes apache#661 from eolivelli/plugins-upgrade, closes apache#606
We had some DNS issues today and various TestRegionAwareEnsemblePlacementPolicy tests were failing for me. The LOG warning in RackawareEnsemblePlacementPolicyIml was not printing the right variable, which would have given a clue. Additionally, the repp.myRegion was set to UNKNOWN, causing incorrect code flow. Added an assert to kill the test as soon as this occurs. Author: Aaron Gresch <[email protected]> Reviewers: Ivan Kelly <[email protected]>, Enrico Olivelli <[email protected]>, Sijie Guo <[email protected]> This closes apache#658 from agresch/agresch_dns_failure
merge of some changes from Yahoo's repo Author: Aaron Gresch <[email protected]> Reviewers: Sijie Guo <[email protected]>, Matteo Merli <[email protected]> This closes apache#669 from agresch/agresch_recycle_entryprocessor
…rver Descriptions of the changes in this PR: While in BOOKKEEPER-628, It is trying to improve/generalize the bookie registration process. This PR is for bookie side, it tries to introduce Bookie registration manager for bookie server. Author: Jia Zhai <[email protected]> Reviewers: Enrico Olivelli <[email protected]>, Sijie Guo <[email protected]> This closes apache#663 from zhaijack/bookie_registration, closes apache#662
…mble placement policy Descriptions of the changes in this PR: This pull request ports the changes from [twitter/bookkeeperfc7e171](twitter-archive/bookkeeper@fc7e171) The changes include: 1. when bookkeeper admin re-replicates a ledger, it will pick a bookie from the available bookies in the cluster to satisfy the placement constraint. (apache#596) 2. hence, remove `targetBookie` from ReplicationWorker, because the parameter will volatile the placement constraint. (apache#583) 3. at the same time, change `LedgerFragement` to represent the number of bookies that need to be check and replicate. a) the ledger checker can use the correct bookie index for verifying the existence of entries in a bookie (for stripping case) b) only read entries one time when need to replicate them to multiple bookies. Author: Sijie Guo <[email protected]> Reviewers: Ivan Kelly <[email protected]> This closes apache#641 from sijie/twitter_autorecovery_fixes, closes apache#596, closes apache#583
Descriptions of the changes in this PR: - Add support for persisting bookie status - Add configuration to enable/disable this feature - Add test cases - Improve bookie status stat It also includes changes for BOOKKEEPER-754 (flush ledger storage after replaying journal) Author: Sijie Guo <[email protected]> Author: Yiming Zang <[email protected]> Reviewers: Yiming Zang <[email protected]>, Enrico Olivelli <[email protected]> This closes apache#266 from sijie/server_side_crc32, closes apache#265
These packages include: - feature - processor - shims - stats - streaming - versioning - zookeeper not fully enabled in conf package. Author: Sijie Guo <[email protected]> Reviewers: Jia Zhai <None> This closes apache#676 from sijie/fix_checkstyles, closes apache#675
This avoids the autoboxing on Integers and allocations of cells for the hashset. This also implies using wrapped int[] object for the write set in the DistributionSchedules and PlacementPolicies. This patch was originally submitted as dc7933b on the yahoo-4.3 branch, though this has been modified extensively to remove the dependency on carrotsearch hppc and to allow it to work with placement policies which didn't exist at the time of the original patch. Author: Ivan Kelly <[email protected]> Reviewers: Enrico Olivelli <[email protected]>, Sijie Guo <[email protected]> This closes apache#657 from ivankelly/yahoo-backports
This change was originally commit e2e7786 in the yahoo-4.3 branch. Author: Matteo Merli <[email protected]> Reviewers: Sijie Guo <[email protected]> This closes apache#679 from ivankelly/yahoo-bp-3
test-things-on-github
force-pushed
the
pr-test-1
branch
from
e202d95 to
2a5be6c
Compare
Copy site directory in order to start new release notes for 4.5.1 Author: eolivelli <[email protected]> Reviewers: Sijie Guo <[email protected]> This closes apache#680 from eolivelli/release-notes-451-copy
Avoid creating a new PendingAddOp object for each entry added, thus saving on garbage. Originally commit 55ba472 on the yahoo-4.3 branch. Author: Ivan Kelly <[email protected]> Author: Matteo Merli <[email protected]> Reviewers: Jia Zhai <None>, Sijie Guo <[email protected]> This closes apache#664 from ivankelly/yahoo-bp-1
… to do bookie discover Descriptions of the changes in this PR: while in BOOKKEEPER-628, It is trying to improve/generalize the bookie registration process. This PR follows the work of apache#663, which provide bookie side registration, and it is for client side work, it tries to introduce RegistrationClient for bookkeeper client to do bookie discover. This PR follows the work of apache#663, which provide bookie side registration, Author: Jia Zhai <[email protected]> Reviewers: Sijie Guo <[email protected]> This closes apache#667 from zhaijack/client_registration2, closes apache#666
This change was originally afd0ecb & 75bf0fa on the yahoo-4.3 branch Author: Matteo Merli <[email protected]> Reviewers: Enrico Olivelli <[email protected]>, Jia Zhai <None>, Sijie Guo <[email protected]> This closes apache#665 from ivankelly/yahoo-bp-2
test-things-on-github
force-pushed
the
pr-test-1
branch
from
2a5be6c to
c3b2287
Compare
ivankelly
reviewed
Nov 2, 2017
| @@ -40,6 +40,10 @@ public BookieException(int code, String reason) { | |||
| super(reason); | |||
| } | |||
|
|
|||
| public BookieException(int code, String reason, Throwable t) { | |||
ivankelly
pushed a commit
that referenced
this pull request
Feb 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A pull request with multiple commits