Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stake pool for integration test #141

Merged
merged 18 commits into from
Apr 24, 2024
Merged

Stake pool for integration test #141

merged 18 commits into from
Apr 24, 2024

Conversation

the-headless-ghost
Copy link
Contributor

@the-headless-ghost the-headless-ghost commented Apr 12, 2024 •
edited
Loading

Summary

  • CardanoNode: Added withCardanoStakePoolNodeDevnetConfig
  • DevNet.Wallet: balanceAndSubmit has a new param: key witnesses
  • NodeQueries: Added queryStakePools and queryStakeAddresses
  • CoinSelection: requiredSignatureCount with certificate key wits count support
  • Spec test: startLocalStakePoolNode, registeredStakePoolNode, stakePoolRewards

j-mueller
j-mueller requested changes Apr 17, 2024
View reviewed changes
Copy link
Owner

@j-mueller j-mueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests are good. I just think we can get away without the extra argument.

@the-headless-ghost the-headless-ghost mentioned this pull request Apr 23, 2024
Closed
@the-headless-ghost the-headless-ghost marked this pull request as ready for review April 23, 2024 13:46
j-mueller
j-mueller approved these changes Apr 24, 2024
View reviewed changes
Copy link
Owner

@j-mueller j-mueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@j-mueller j-mueller merged commit beb2d6f into j-mueller:node-1.35.4 Apr 24, 2024
4 checks passed
@the-headless-ghost the-headless-ghost mentioned this pull request Apr 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-mueller j-mueller j-mueller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@the-headless-ghost @j-mueller