Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blockfrost backend for MonadBlockchain #243

Merged
merged 8 commits into from
Dec 10, 2024
Merged

Blockfrost backend for MonadBlockchain #243

merged 8 commits into from
Dec 10, 2024

Conversation

j-mueller
Copy link
Owner

@j-mueller j-mueller commented Dec 4, 2024

We can implement the whole MonadBlockchain interface with blockfrost. Some notes

  • Era is hard-coded to Conway. See note [Protocol Parameter Conversion] for details on extracting conway-era protocol parameters from the API response
  • We try to do some caching on the client. Volatile data (protocol parameters, stake distributions) is erased at the end of each epoch.
  • I tested it manually with a couple of addresses on mainnet

@j-mueller j-mueller marked this pull request as ready for review December 9, 2024 16:38
@j-mueller j-mueller requested a review from koslambrou December 9, 2024 16:38
Copy link
Collaborator

@koslambrou koslambrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see the MonadBlockchain instance in this PR. Is it intentional?

Comment on lines 439 to 447
-- & L.hkdDL .~ _ (_protocolParamsDecentralisationParam pp)
-- & L.hkdExtraEntropyL .~
-- maybe BaseTypes.NeutralNonce (BaseTypes.Nonce . _) (_protocolParamsExtraEntropy pp)
-- & L.hkdExtraEntropyL .~ _ (_protocolParamsExtraEntropy pp)
-- & L.ppProtocolVersionL .~
-- L.ProtVer
-- { L.pvMajor = _ (_protocolParamsProtocolMajorVer pp)
-- , L.pvMinor = _ (_protocolParamsProtocolMinorVer pp)
-- }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bin?

-- TODO
-- stake addresses

-- DONE
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bin?

@j-mueller
Copy link
Owner Author

My bad! I made some commits yesterday but didn't push them

@j-mueller j-mueller merged commit ce5f4bc into main Dec 10, 2024
4 checks passed
@j-mueller j-mueller deleted the j-mueller/issue242 branch December 10, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants