last PR comments

src/pyatmo/const.py

@@ -102,3 +102,6 @@
 ACCESSORY_WIND_TIME_TYPE = "wind_timeutc"
 ACCESSORY_GUST_STRENGTH_TYPE = "gust_strength"
 ACCESSORY_GUST_ANGLE_TYPE = "gust_angle"
+
+# 2 days of dynamic historical data stored
+MAX_HISTORY_TIME_FRAME = 24 * 2 * 3600

src/pyatmo/home.py

@@ -124,9 +124,9 @@ def update_topology(self, raw_data: RawData) -> None:
 
     async def update(self, raw_data: RawData, do_raise_for_reachability_error=False) -> None:
         """Update home with the latest data."""
-        num_errors = 0
+        has_error = False
         for module in raw_data.get("errors", []):
-            num_errors += 1
+            has_error = True
             await self.modules[module["id"]].update({})
 
         data = raw_data["home"]
@@ -164,8 +164,8 @@ async def update(self, raw_data: RawData, do_raise_for_reachability_error=False)
                     ],
                 )
 
-        if (do_raise_for_reachability_error and
-            num_errors > 0
+        if (do_raise_for_reachability_error
+            and has_error
             and has_one_module_reachable is False
             and has_an_update is False
         ):

src/pyatmo/modules/base_class.py

@@ -10,7 +10,7 @@
 from operator import itemgetter
 from typing import TYPE_CHECKING, Any
 
-from pyatmo.const import RawData
+from pyatmo.const import RawData, MAX_HISTORY_TIME_FRAME
 from pyatmo.modules.device_types import DeviceType
 
 if TYPE_CHECKING:
@@ -60,10 +60,6 @@ class EntityBase:
     name: str | None
 
 
-# 2 days of dynamic historical data stored
-MAX_HISTORY_TIME_FRAME = 24 * 2 * 3600
-
-
 class NetatmoBase(EntityBase, ABC):
     """Base class for Netatmo entities."""