Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exposing config to cache ReadDir() response #162

Merged
merged 5 commits into from
May 22, 2024

Conversation

raj-prince
Copy link
Contributor

@raj-prince raj-prince commented May 9, 2024

  • Exposing functionality to cache the ReadDir() response in the kernel. This will drastically improve the performance of 2nd listing.
  • Also, created another flag KeepDirContentPageCache, by setting it false invalidate the previously cached listing response.

@raj-prince raj-prince marked this pull request as ready for review May 9, 2024 11:07
@raj-prince raj-prince changed the title ReadDir response cache POC Exposing configuration to cache ReadDir() response May 9, 2024
Copy link
Collaborator

@stapelberg stapelberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have an example for how to use this? Could any of the existing examples be adjusted to exercise this feature?

@raj-prince raj-prince requested a review from stapelberg May 20, 2024 17:23
@raj-prince
Copy link
Contributor Author

Do you have an example for how to use this? Could any of the existing examples be adjusted to exercise this feature?

Added as part of samples/caching_fs.

@raj-prince raj-prince changed the title Exposing configuration to cache ReadDir() response Exposing config to cache ReadDir() response May 21, 2024
@stapelberg stapelberg merged commit a2f23ee into jacobsa:master May 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants