Skip to content

fix missing album and artist images in search results view#1010

Open
runkelstein wants to merge 1 commit into
jaedb:masterfrom
runkelstein:master
Open

fix missing album and artist images in search results view#1010
runkelstein wants to merge 1 commit into
jaedb:masterfrom
runkelstein:master

Conversation

@runkelstein
Copy link
Copy Markdown

This is a pull request to fix an issue with the search result view, where album and artist images were missing in my case.

  • album images are missing, because (atleast in my case) the search result items do not include image paths. However the application is already requesting for each album an image, but they then get "reduced" into store.core.images not into the search results. The search result view however is using the the data from store.core.search_results
  • artist images were missing in search list view too (alteast in my case), because I don't use spotify. But since it worked for the artist view I looked it up and saw there is a way to load them via discogs. This was used somewhere else alongside with spotify. I added therefore the missing line of code to GridItem and ListItem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant