Skip to content

Commit

Permalink
Fix -- under some circumstances, chart ready event might be constantl…
Browse files Browse the repository at this point in the history
…y invoked
  • Loading branch information
Jago (C. Santiago Melon) committed Oct 13, 2020
1 parent fbd0e95 commit 3779b22
Show file tree
Hide file tree
Showing 13 changed files with 33 additions and 21 deletions.
6 changes: 4 additions & 2 deletions dist/bundles/countries-map.umd.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/bundles/countries-map.umd.js.map

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/bundles/countries-map.umd.min.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/bundles/countries-map.umd.min.js.map

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

6 changes: 4 additions & 2 deletions dist/fesm2015/countries-map.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/fesm2015/countries-map.js.map

Large diffs are not rendered by default.

6 changes: 4 additions & 2 deletions dist/fesm5/countries-map.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/fesm5/countries-map.js.map

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "countries-map",
"version": "3.1.0",
"version": "3.1.1",
"description": "World countries datamaps component for Angular, based on Google GeoCharts",
"license": "MIT",
"author": "Jago MF <[email protected]>",
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "countries-map",
"version": "3.1.0",
"version": "3.1.1",
"description": "World countries datamaps component for Angular, based on Google GeoCharts",
"license": "MIT",
"author": "Jago MF <[email protected]>",
Expand Down
6 changes: 4 additions & 2 deletions src/app/modules/countries-map/countries-map.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -163,8 +163,10 @@ export class CountriesMapComponent implements OnChanges, OnDestroy {
}

private onChartReady(): void {
this.innerLoading = false;
this.chartReady.emit();
if (this.innerLoading) {
this.innerLoading = false;
this.chartReady.emit();
}
}

private onCharterror(error: ChartErrorEvent): void {
Expand Down

0 comments on commit 3779b22

Please sign in to comment.