Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.6.26 - Rollup Grouping support, FIRST/LAST/MOST/AVERAGE bugfixes #592

Merged
merged 8 commits into from
May 17, 2024

Conversation

jamessimone
Copy link
Owner

  • Adds new RollupGrouping__mdt, which at the moment has no fields on it. I am considering the promotion of Rollup__mdt.RollupOperation__c to a global value set in the future, which would allow for fun possibilities like taking the max of two sums. When two or more children Rollup__mdt records have their Rollup Grouping lookup field set and they are properly pointed to the same parent field, all children records will be retrieved and accounted for prior to setting the parent rollup field
  • Fixes Hitting SOQL Too Many Query Rows with AVERAGE #589 by updating the rollup calculators for AVERAGE, FIRST, LAST, and MOST, all of which weren't able to handle parents with more than 50k children during batch full recalcs
  • Releases an updated version of the Extra Code Coverage plugin

Copy link

codecov bot commented May 17, 2024

Codecov Report

Attention: Patch coverage is 98.64865% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 96.64%. Comparing base (aebf83b) to head (dcf77cb).

Current head dcf77cb differs from pull request most recent head eada786

Please upload reports for the commit eada786 to get more accurate results.

Files Patch % Lines
rollup/core/classes/RollupState.cls 93.93% 2 Missing ⚠️
rollup/core/classes/RollupAsyncProcessor.cls 98.91% 1 Missing ⚠️
rollup/core/classes/RollupCalculator.cls 99.25% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #592      +/-   ##
==========================================
+ Coverage   96.61%   96.64%   +0.02%     
==========================================
  Files          32       33       +1     
  Lines        6705     6821     +116     
  Branches       61       61              
==========================================
+ Hits         6478     6592     +114     
- Misses        222      224       +2     
  Partials        5        5              
Flag Coverage Δ
Apex 96.87% <98.64%> (+0.02%) ⬆️
LWC 92.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jamessimone jamessimone merged commit 8fa1867 into main May 17, 2024
@jamessimone jamessimone deleted the v1.6.26 branch May 17, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hitting SOQL Too Many Query Rows with AVERAGE
2 participants