Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Show spinner/logline during initial feed retrieval #230

Merged
merged 2 commits into from
Jan 4, 2025

Conversation

janw
Copy link
Owner

@janw janw commented Jan 4, 2025

No description provided.

@janw janw changed the title feat: Show message for initial feed retrieval feat: Show spinner/logline during initial feed retrieval Jan 4, 2025
Copy link

codecov bot commented Jan 4, 2025

Codecov Report

Attention: Patch coverage is 86.20690% with 4 lines in your changes missing coverage. Please review.

Project coverage is 92.52%. Comparing base (f2b89d5) to head (39520d6).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
podcast_archiver/utils/__init__.py 71.42% 1 Missing and 1 partial ⚠️
podcast_archiver/utils/progress.py 75.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #230      +/-   ##
==========================================
- Coverage   92.57%   92.52%   -0.06%     
==========================================
  Files          29       29              
  Lines        1306     1324      +18     
  Branches      129      131       +2     
==========================================
+ Hits         1209     1225      +16     
+ Misses         68       66       -2     
- Partials       29       33       +4     
Files with missing lines Coverage Δ
podcast_archiver/base.py 82.97% <ø> (+1.34%) ⬆️
podcast_archiver/console.py 100.00% <ø> (ø)
podcast_archiver/models/feed.py 91.45% <100.00%> (-1.71%) ⬇️
podcast_archiver/processor.py 92.17% <100.00%> (+0.50%) ⬆️
podcast_archiver/utils/__init__.py 85.08% <71.42%> (-0.90%) ⬇️
podcast_archiver/utils/progress.py 86.58% <75.00%> (+2.37%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@janw janw merged commit dfa7d3f into main Jan 4, 2025
13 of 14 checks passed
@janw janw deleted the improve-initial-loading-status branch January 4, 2025 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants