Skip to content
This repository has been archived by the owner on Nov 25, 2022. It is now read-only.

make the data_migration table name work with table_name_prefix and ta… #11

Open
wants to merge 1 commit into
base: rails4
Choose a base branch
from

Conversation

polarlights
Copy link

I know the gem from a friend. I read the source code and I see the code below:

#lib/active_record/data_migration.rb#L12
def table_name
    "#{table_name_prefix}data_migrations#{table_name_suffix}"
end

However, the schema file under the templates folder, the table name is fixed. I think it will be better if we can support the table_name_prefix and table_name_suffix as your wrote in the code.

It's not a bug, just to make it better. :)

@jasonfb
Copy link
Owner

jasonfb commented May 25, 2016

Thank you !

I will pull this against a few of my apps, configure & run it, and then merge this in assuming everything looks good. Please give me a few days. I will be sure to put this on my TOOD list

@jasonfb
Copy link
Owner

jasonfb commented May 25, 2016

So sorry I don't know why I didn't see this 3 weeks ago when you submitted it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants