This repository was archived by the owner on Feb 26, 2025. It is now read-only.
Allow adding optional VTIMEZONE component to ICS files #62
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, first off thank you for the library, it's been very useful to us.
We've been running into the issue described at #46 which results in
.ics
files generated by this library being imported into Outlook with start and end times 1 hour offset from what they should be. Updating these.ics
files to include a VTIMEZONE component following the spec fixes the issue for us.I see that an abandoned PR to build VTIMEZONE functionality into react-add-to-calendar-hoc has been closed here: #45
This kind of functionality would be ideal for us, but in lieu of that we can resolve our issue if we simply have an option to insert pre-constructed VTIMEZONE text into the right place during react-add-to-calendar-hoc's
buildShareFile
. This pull request implements the logic needed to insert the VTIMEZONE component in the right place in the.ics
file.We're using https://github.com/add2cal/timezones-ical-library along with this glue code to integrate the two libraries: