Skip to content

Commit

Permalink
add computeFilter to Columns db table
Browse files Browse the repository at this point in the history
here we can store the name of the filter to load, or nothing if we just want everything.
This can then also be taken into account when writing the data.
  • Loading branch information
JorisGoosen committed Feb 17, 2025
1 parent 32ec424 commit ddb694c
Show file tree
Hide file tree
Showing 3 changed files with 19 additions and 5 deletions.
19 changes: 16 additions & 3 deletions CommonData/databaseinterface.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -52,10 +52,23 @@ void DatabaseInterface::upgradeDBFromVersion(Version originalVersion)
if(originalVersion < "0.19.2" && !tableHasColumn("Filters", "name"))
runStatements("ALTER TABLE Filters ADD COLUMN name TEXT;");

if(originalVersion <= "0.19.3" && !tableHasColumn("Filters", "dropLevels"))
if(originalVersion <= "0.19.3")
{
runStatements("ALTER TABLE Filters ADD COLUMN dropLevels INT;");
runStatements("UPDATE Filters SET dropLevels = 1;"); //Previously dropLevels was always on, so loading an older jasp-file should have this enabled
if(!tableHasColumn("Filters", "dropLevels"))
{
runStatements("ALTER TABLE Filters ADD COLUMN dropLevels INT;");
runStatements("UPDATE Filters SET dropLevels = 1;"); //Previously dropLevels was always on, so loading an older jasp-file should have this enabled
}


if(!tableHasColumn("Columns", "computeFilter"))
{
runStatements("ALTER TABLE Columns ADD COLUMN computeFilter TEXT DEFAULT \"\";");
runStatements("UPDATE Filters SET dropLevels = 1;"); //Previously dropLevels was always on, so loading an older jasp-file should have this enabled
}



}

transactionWriteEnd();
Expand Down
3 changes: 2 additions & 1 deletion CommonData/internalDbDefinition.sql
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,8 @@ CREATE TABLE Columns
name TEXT,
title TEXT,
description TEXT,
columnType TEXT,
columnType TEXT,
computeFilter TEXT DEFAULT "",
colIdx INT,
autoSortByValue INT,
invalidated INT NULL,
Expand Down
2 changes: 1 addition & 1 deletion Desktop/components/JASP/Widgets/ComputeColumnWindow.qml
Original file line number Diff line number Diff line change
Expand Up @@ -302,8 +302,8 @@ FocusScope
anchors.top: helpButton.top
onClicked: { forceActiveFocus(); computedColumnContainer.applyComputedColumn() }
toolTip: qsTr("Click to compute column")

}


JaspControls.RectangularButton
{
Expand Down

0 comments on commit ddb694c

Please sign in to comment.