-
-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MSIX #5393
MSIX #5393
Conversation
* tweaks for ZIP * more zip tweaks
QMLComponents/utilities/appdirs.cpp
Outdated
auto env = DynamicRuntimeInfo::getInstance()->getRuntimeEnvironment(); | ||
bool useAppdata = env != DynamicRuntimeInfo::MSIX; | ||
auto env = DynamicRuntimeInfo::getInstance()->runtimeEnvironment(); | ||
bool useAppdata = env != RuntimeEnvironment::MSIX && env != RuntimeEnvironment::ZIP; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
? why did you add this.
Dont we want ZIP stuff to stay in the zip folder as much as possible?
I mean it will work fine but might collide if someone has normal jasp installed as well.
If we do this we should make some other changes as well
The order of targets is still: Because I had to manually create "Install" in the buildfolder for the process to continue |
The order is exactly as stated in the buildbotscript. That auto builds. |
Ok ill try it again from scratch, cause it fails anyway with:
Although I guess the versionnumber is not accepted? |
I will boot my windows partition. I doubt 0.18 -> 0.19 could cause an issue. Then again this is windows |
Yeah maybe its the I dont know, anyway the missing ingredient is probably |
yes 1000 is okay but 0000 is not because ... who knows |
breaks my beautiful hack |
Well, I have no idea what is going wrong, but I do not get the |
Version numbering of msix: We once had a problem with four digits .msi version number and had to be careful with it haha |
Yeah lets just let msix package version diverge from jasp version whenever necessary |
@JorisGoosen you can also use the buildbot if its going to cost a lot of time |
Well I would like to be able to build it locally before merging it into development you know... Where does |
The install folder is created by the install target. I have not altered that. |
did you alter the CMAKE_INSTALL_PREFIX? |
or CMAKE_BINARY_DIR |
Ok now I can get it to build and get all the way to building a set of 'msix'es so so far so good! But I cant install them without them signed properly and I dont know how to do it. So I cant finish testing because I have no idea whether my msixes work. |
added some docs |
Builds 3 MSIXs:
AppxManifests for these options will likely diverge over time.
Adds a class that wrangles the static and dynamic runtime files used to determine if and how to initialize Jasp on first start.
Still generates the MSI for now (sign troubles).
I will add some docs on how to add the self signed cert to trusted sources in a different PR.
For testing:
The latest MSIX-branch builds of windows zip, msi and msix on the nightlies page are build with theses changes.