R Syntax: Load QML Controls as QML Module #5785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The QML Module is also a plugin. All versions in QML import statement must be removed.
Remove the CommonData to the QML Comnponent. Only the Audit analyses use the CommonData objects (via the Filter object), but this leads to unexpected error: the sqlite library is added in the translation unit of the QML Component library. Furthermore, n order to use the Filter object in the QML Component the whole DataSet object was exposed to the QML Component, which is completely inconsistent with the Provider/Consumer pattern used in the VariableInfo. So in order to still be able to use the Filter object in the Audit analyses, callback functions are used instead, which are set in the DesktopCommunicator object.
Use QML_ELEMENT Remove import version in other QML files
…o inside singleton() (but without creating the actual tablestructure, this remains the prerogative of DataSetPackage)
linux compiles and runs
linking fails under a variety of circumstances...
more
more
JorisGoosen
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the QML Components as a QML Module (by using the qt_add_qml_module cmake function).
This makes also possible to use this module as a plugin: this is needed for the R Syntax project
All versions in QML import statement must be removed.
No qmldir needed (it is generated automatically), and no need to register all the base QML objects: they are automatically registered via the QML_ELEMENT macro.
The QMLComponents module is a static library. To make it a shared library would be really painful on Windows: all the library (Common, CommonData), should be also dynamic, and export their object with dll_export macros, in order to solve all the problems correctly of static members. Also an extra dynamic library would be necessary to collect all the objects that are used in QMLComponents and Desktop.
As static library, there is no initialization of the module with the QML Engine, so the context objects needed by the QML Controls (jaspTheme, preferencesModel), some variables (DEBUG_MODE...), and the registration of the enum types must be done outside the module. This is done by the MainWindow class, and this must be done by the R package that will call the QML form.