Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix to cell value vertical-align in tables #5793

Open
wants to merge 4 commits into
base: development
Choose a base branch
from

Conversation

shun2wang
Copy link
Contributor

@shun2wang shun2wang commented Feb 19, 2025

Fix: https://github.com/jasp-stats/INTERNAL-jasp/issues/2794

Not sure why we set to 'top', the browser user agent stylesheet auto set to middle/inherit by default so we just remove it.
Or we can specify it to be fixed to center alignment, any preference?

Note: Maybe the unit test .jasp files also need to be updated because the CSS style string will be changed.

@JorisGoosen
Copy link
Contributor

I think I would prefer it to specify what we want there. Cause maybe whatever we inherit changes later?

@JorisGoosen
Copy link
Contributor

Ok, I am on a weird arch linux setup here and cannot make screenshots but exponents are still not aligned with other numbers...

@JorisGoosen
Copy link
Contributor

Ah @FBartos gave me the great idea to do as the young people do:
screenshot

@JorisGoosen
Copy link
Contributor

Maybe bottom alignment is better?

@shun2wang
Copy link
Contributor Author

shun2wang commented Feb 21, 2025

Well, this is actually due to the fact that the cell elements with exponent and the numeric elements without indices are not the same height, a height difference of 1-2 pixels by auto adjusted.

@shun2wang
Copy link
Contributor Author

shun2wang commented Feb 21, 2025

I also adjusted latex img vertical align in tables, test case in jaspTestModule-> test jaspHtml.

@JorisGoosen
Copy link
Contributor

Well, its a bit better now, but now the exponent slightly overlaps the row above it...

signal-2025-02-24-151845_002

I think right now in general all the rows in the resulttables are a bit cramped.

As far as the latex thing goes, im not sure what you changed or where I would see this in the testcase?
Am I overlooking some exponents somewhere?

@shun2wang
Copy link
Contributor Author

shun2wang commented Feb 24, 2025

ah! seems there will be differences on different screens. I'll think about it...

for latex things: the latex image is not vertical align middle in table rows with numbers, the commit will change it,not related with exponents.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants