Monetary columns and locale sensitive number display #5794
Conversation
…ange language+territory codes however, once a Label is created it keeps the particular punctuation etc from the locale when it changed...
…entages well also make sure the doubles in the double array are not sperated by a comma :s
and tweaking the doublevalidator a bit more just convert to english/default locale thing when checking for decimals also add setLocal thing to resultsJsInterface, now to think of where to put that information
Sort of backwards compatible?
There was a problem hiding this comment.
In addition to two small suggested changes, there are other potentially serious problems:
- Label-Value combination change is not synchronously? when you change the locale, see that combination it's different.
- Edit value with decimal will crash JASP, error msg:
replaceDoublesTillLabelsRowWithLabels choked on a temp-label that cant be converted to double???
3.While import SPPS_Debug.sav inNumericRestrictedOrdinalfrom debug.sav the decimal point mixed both.and,. - Maybe setting options should be moved to "Result" and put it with
Table optionstogether.
| @@ -3,30 +3,44 @@ | |||
|
|
|||
There was a problem hiding this comment.
| #include <functional> |
I cannot compiling it without this with MSVC, and buildBot on Windows also failed.
There was a problem hiding this comment.
Ill have a look
There was a problem hiding this comment.
Took me a while to realize that I had to put in format = "monetary" instead of type = "monetary but after that it looks quite nice. Except for the fact that Euro's (at least in most European countries) uses , as the decimal separator and . as the thousand separator. Furthermore it looks nice.
|
@shun2wang Sorry, I accidentally requested a re-review from you. You can ignore this. |
|
Yes but do we even want to allow comma's as digital separators? Maybe we should, but it sseems like it could be terribly confusing |
Yeah so the dots/commas is dependent on locale not on the currency. Because otherwise you would get different formatting for lets say, a column of yen next dollars next to euros? Seems unwanted |
Yeah this is a more broad question actually, also see the following: This adding of thousands-separators is a sideeffect of making the numbers locale dependent. I also added a "Use American English locale" for numbers checkbox in the settings. Although if we dont want those maybe I can find some way to turn them off? |
Co-authored-by: Shun Wang <[email protected]>
Well, the label is a stringified version of the value, so it has the locale dependent setting.
Editing it in the labeleditor or in the data?
Hey that is a good one, ill have a look.
The language option? |
In the data. |
Hmm, doesnt crash for me on linux, but Ill check later on a windows system |
|
So you can see the crash also on Linux Debug build while press Enter |
Ah yes, now I can reproduce... |
fixes shuns crash
…ging to the selected language also fix popups
|
I think Ive fixed the crash shun encountered. Ive also made the "alternative" locale option a bit more comprehensive, like crazy comprehensive :p There are new builds running, where the default locale used is the one linked to the chosen language, unless the alternative is selected: |
|
Wel Ive also changed the sorting of the languages and territories a bit, although it will be missing from (some?) of the builds. |
|
Ok, so now the alternative locale actually gets stored... |
This PR implements https://github.com/jasp-stats/INTERNAL-jasp/issues/1744 where a "monetary" format is added.
The format can just be "monetary" and then by default euro is chosen, to add a currency just do something like "monetary:USD" or "monetary:EUR".
This also implements almost everything in jasp-stats/jasp-issues#39 as far as localizing numbers and money go.
Date, time and or datetime colums are not added in this pr but the localisation stuff added now should help implementing it.
Ill also trigger some builds