try to load library from /usr/lib/jni if property jna.boot.library.path is not set #1499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th is not set This patch moves getMultiarchPath() to Platform so that it is available for both Library and NativeLibrary. It also fixes the library path on the aarch64, armhf and ppc64el platforms. See https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1028374 for more info.
matthiasblaesing
requested changes
Feb 1, 2023
…rary.path is not set
|
I finally had time to work on this. Sorry for the long delay. |
|
Sorry, but I don't think this has merrit in its current form. I see why it is tempting, but JNA can do dirty things in private methods, that are only called when they may be called, the same is not true for public methods. The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch moves getMultiarchPath() to Platform so that it is available for both Library and NativeLibrary.
It also fixes the library path on the aarch64, armhf and ppc64el platforms.
See https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1028374 for more info.