Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[demo] use QuickJs for the JavaScript provider #169

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

andreaTP
Copy link
Member

@andreaTP andreaTP commented Jan 6, 2025

Back from holidays and happy to help!
Since code is worth thousands of words, I attempted a first(demo) integration of QuickJs/Javy to showcase one possible solution to #160 with a compatible API.

A few notes on this first(unpolished) attempt:

  • the used Javy version is slightly outdated ( comes from )
  • the quoting of strings is primitive and will break with more complex scripts
  • we are using StdErr to return the result, which can be sub-optimal

Happy to hear feedback and iterate if this is aligned with the direction of the project!

@andreaTP andreaTP requested a review from csviri January 6, 2025 14:01
@andreaTP andreaTP marked this pull request as draft January 6, 2025 14:01
@andreaTP
Copy link
Member Author

andreaTP commented Jan 6, 2025

note, the failure of: GlueRelatedResourcesTest.simpleRelatedResourceUsage is caused by incorrect handling of escape sequences.

@csviri
Copy link
Collaborator

csviri commented Jan 7, 2025

Ahh wow, thank you! will take a deeper look bit later hopefully end of this week

@andreaTP
Copy link
Member Author

andreaTP commented Jan 7, 2025

Sounds good, let me know if/how you want to proceed or if you want an exploration in a different direction 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants