-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for RN >= 0.59 #15
Conversation
@mppperez i'm trying to use your branch to test it but I get this output in console:
(":" is missing) |
as suggested by another pull request adding babel-traverse and babylon make the error disappear, but still no obfuscated files anywhere.
just to help in debug i've this configuration: metro.config.js
transformer.js
|
@paomosca I suspect it is because of wrong filter... try:
|
@paomosca sorry for the late response. First of all thanks for the hint: just fixed the typo in README. You're right: I've just merged the pull request of @maksim-tolo into this one to have this fix included. With this changes everything works fine for me. I hope @dusan-dragon were able to help you with his hint. |
@ds300 any chance that we can get this merged into master and make a new release? |
Following this. Hope this get merged in soon. We have a big need for this in a bigger project we are working on for a customer. |
Bump. @ds300 can you merge this PR in please? |
merged, but i can't release a new version with this fix |
Hi guys, I found out that if you will use directly javascript-obfuscator library you can get way better results. But it takes more time to integrate into build process. Just wanted to mention that it is also an option. |
Can someone please release a new version to |
@dusan-dragon |
@rooque during the build process of app there is a step where all JS is bundled / compiled (from typescript for example) to 1 big file. You can just hook into build process and after bundling apply javascript-obfuscator to that file, after that continue with normal build process.... That being said, not sure if it is needed anymore because on the newest react-native version I think Hermes is supported for both android and IOS so basically there is no JS file, but instead you wil find "bytecode" - code compiled for Hermes. |
Got it, thanks! |
Regarding to #10 this library doesn't support RN >= 0.59.
The included changes made it work for me with RN 0.60.3 again. Please review and merge if possible.
BR