Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments #137

Merged
merged 5 commits into from
Jun 21, 2021
Merged

Comments #137

merged 5 commits into from
Jun 21, 2021

Conversation

shathee
Copy link
Contributor

@shathee shathee commented Mar 22, 2021

Submitted for merge

shathee added 4 commits March 4, 2021 17:00
Section 1 & 2
Done upto line 121
last updated
@CLAassistant
Copy link

CLAassistant commented Mar 22, 2021

CLA assistant check
All committers have signed the CLA.

@msisaifu
Copy link
Contributor

msisaifu commented Apr 8, 2021

ল্যাঙ্গগুয়েজ টার্ম হিসেবে comment কে মন্তব্য এর পরিবর্তে কমেন্ট হিসেবে উল্লেখ করলে পাঠকদের জন্য বোঝা সুবিধাজনক হবে মনে হয়।
প্রথম কন্ট্রিবিউশনের জন্য ধন্যবাদ।

@shathee
Copy link
Contributor Author

shathee commented Apr 12, 2021

@msisaifu আমি কি মন্তব্য এর জায়গায় কমেন্ট করে আবার পুল রিকোয়েস্ট করবো?

@msisaifu
Copy link
Contributor

হ্যাঁ এটাই ভালো হবে

মন্তব্য changed to কমেন্ট  as suggested by the reviewer
@shathee
Copy link
Contributor Author

shathee commented Apr 17, 2021

@msisaifu done!

Copy link
Member

@jaamaalxyz jaamaalxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ভালো হয়েছে @shathee

@jaamaalxyz jaamaalxyz merged commit 225e982 into javascript-tutorial:master Jun 21, 2021
@javascript-translate-bot

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants