Skip to content

Added support for Python 3.13 #756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added support for Python 3.13 #756

wants to merge 1 commit into from

Conversation

ulgens
Copy link
Member

@ulgens ulgens commented Oct 26, 2024

No description provided.

@ulgens ulgens self-assigned this Oct 26, 2024
@WisdomPill
Copy link
Member

WisdomPill commented Oct 26, 2024

redis-py still doesn't support python3.13 officially yet, but we can give it a go.

@WisdomPill
Copy link
Member

Any plans for it? @chayim @dvora-h

@foarsitter
Copy link
Contributor

@ulgens do not forget to add the classifier for python 3.13 to setup.cfg.

@ulgens
Copy link
Member Author

ulgens commented Oct 26, 2024

@WisdomPill I was just checking redis-py, I'll try to create a PR there too, hopefully in the following week.

setup.cfg Outdated
@@ -60,9 +61,10 @@ envlist =
# tests against released versions
py{38,39}-dj{42}-redislatest
py{310,311,312}-dj{42,50,51}-redislatest
py313-dj51-redislatest
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not do like on line 67?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line aims to add Python 3.13 (supported only by Django 5.1) and the latest Redis to the matrix. Not sure how it can be more like line 67, an example would be nice.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
py313-dj51-redislatest
py313-dj51-redis{latest,master}

and remove py313-dj51-redismaster from line 66

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I see. I can apply that, but there is contextual grouping between tests against released versions and tests against unreleased versions in that block. Do we want to change that?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

python3.13 is not yet supported by redis-py officially so I guess we can consider it unreleased 😄

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

redis-py started supporting Python 3.13 in their 6.0.0. release: https://github.com/redis/redis-py/releases/tag/v6.0.0

Base automatically changed from update_docs_supported_versions to master October 26, 2024 09:48
@ulgens
Copy link
Member Author

ulgens commented Oct 26, 2024

@ulgens do not forget to add the classifier for python 3.13 to setup.cfg.

It's in place right now. Thank for the reminder.

@chayim
Copy link

chayim commented Nov 17, 2024

@vladvildanov I think this is you now.

@robd003
Copy link

robd003 commented May 26, 2025

@ulgens / @WisdomPill / @vladvildanov Just wanted to nudge and see if this could get moved forward. Redis-py has had Python 3.13 support for a while.

@ulgens
Copy link
Member Author

ulgens commented May 26, 2025

@robd003 I rebased the branch and will be fixing the CI failures if there are any.

@chayim @WisdomPill @vladvildanov How can we move this PR forward?

@ulgens ulgens marked this pull request as ready for review May 26, 2025 07:49
@ulgens
Copy link
Member Author

ulgens commented May 26, 2025

Also, it seems I can just merge my own PR. We may want to check the repository permissions.

Copy link
Contributor

@foarsitter foarsitter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -37,21 +37,26 @@ jobs:
- django-version: '4.2'
redis-version: 'latest'
python-version: '3.9'

# Django 5.1 and python 3.13 with latest redis
- django-version: '5.1'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not django 5.2?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants