Add Autoincrementing sort value for reverse relationship modification #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 13, 2020 15:24
…ignal listener should be used instead.
EricHigdon
changed the title
added 6 commits
January 15, 2020 08:56
…t accept keyword arguments (**kwargs)
clintonb
requested changes
Jan 15, 2020
| @@ -1,6 +1,7 @@ | |||
| [pycodestyle] | |||
| max_line_length=120 | |||
| exclude=migrations | |||
| ignore=W0613 | |||
There was a problem hiding this comment.
If you need to disable this, use # pylint: disable=unused-argument at the appropriate location. Do not ignore warnings globally without a discussion. Also, this won't work because Pylint is configured in pylintrc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When modifying a sortedm2m relationship from the "to" model admin, the default sort value of 0 is used, which means new instance is added to the top of the sorted list. Ideally, new records would be sorted last be default.
Adding an m2m_changed listener for the intermediate model allows us to make sure that new records have a sort value higher than the last item already in the list.