implement magnet #29
Draft
implement magnet #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build PreviewYou can find files attached to the below linked Workflow Run URL (Logs).
|
blockninja124
approved these changes
Feb 3, 2025
| @@ -21,39 +22,59 @@ | |||
| * @see BlockWithEntity | |||
| * @param <E> The entity class to be using | |||
| */ | |||
| public abstract class BlockEntityWithEntity<E extends Entity> extends BlockEntity implements ParticleBlockEntity { | |||
| private UUID entityUUID; | |||
| public abstract class BlockEntityWithEntity<E extends Entity & IAttachableEntity> extends BlockEntity implements ParticleBlockEntity { | |||
There was a problem hiding this comment.
Do we need to implement particle block entity here? I'm assuming it is necessary so that these block entities can be used for thrusters and such. Though the magnet blocks could probably just make particles with particle tick and redstone strength for pole Color (red/blue) to help visualise what magnets are opposing.
There was a problem hiding this comment.
I do not know why its called ParticleBlockEntity, it should actually called TickingBlockEntity, because it just handling ticks
There was a problem hiding this comment.
Ah, whoops? Strange it still kinda worked though
src/main/java/net/jcm/vsch/blocks/entity/MagnetBlockEntity.java
Outdated
Show resolved
Hide resolved
Move magnet configs into a separate section, and change defaults
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.