v0.5.5: fix event-loop starvation under load; +115 lines coverage

Converted 14 FastAPI endpoints from `async def` to plain `def` so
FastAPI runs them in a threadpool. A single slow yfinance call was
freezing uvicorn's event loop, queuing every concurrent request —
including the HTML page — and causing 30s page.goto timeouts under
parallel test load. Same freeze would hit real users during Yahoo
rate-limit events. `upload_transactions` stays async (needs
`await file.read()`); `startup_event` stays async (FastAPI requirement).

Also: main.py coverage 72% → 89% via 13 new targeted unit tests
(upload pipeline, exchange-rate fallback, update-market-data ticker
resolver and Yahoo fallback, refresh-live-prices error branches,
purge/shutdown error paths, ensure_indices_exist rollback). Playwright
`page.goto` switched to `wait_until="domcontentloaded"`. Suite now
passes 5/5 consecutive parallel runs (224 tests).

FastAPI app.version bumped from stale "0.4.0" to track pyproject.toml.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: jdrumgoole

CHANGELOG.md

@@ -5,6 +5,17 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [0.5.5] - 2026-04-14
+
+### Fixed
+- **Event-loop starvation under load (production bug)**: 14 FastAPI endpoints were declared `async def` while doing sync blocking I/O (yfinance HTTP calls, SQLAlchemy queries). A single slow upstream call froze uvicorn's event loop, queuing every concurrent request — including the HTML page — until it completed. Converted all non-awaiting endpoints to plain `def` so FastAPI runs them in a threadpool. Eliminates 30s `page.goto` timeouts seen under parallel test load and prevents the same freeze under real user load with slow upstream APIs.
+- **FastAPI `app.version`**: was stuck at `"0.4.0"`, now tracks `pyproject.toml` version.
+
+### Testing
+- **Coverage for `main.py`: 72% → 89%** (+115 lines). Added 13 targeted unit tests covering upload pipeline (new-stock insert, duplicate skip, held-stock filtering, FMP live-price branch, index update exceptions), exchange-rate Yahoo fallback paths, `update-market-data` ticker auto-resolve and Yahoo fallback, `refresh-live-prices` error branches, purge/shutdown error paths, and `ensure_indices_exist` rollback.
+- **Playwright fixture flakiness eliminated**: switched `page.goto` to `wait_until="domcontentloaded"` in shared_page, CSV, and Dutch e2e fixtures. Combined with the event-loop fix, the full suite now passes 5/5 consecutive parallel runs (was 2–3/5 before).
+- **224 tests total**, stable across 5 consecutive parallel runs.
+
 ## [0.5.4] - 2026-04-10
 
 ### Fixed

pyproject.toml

@@ -1,6 +1,6 @@
 [project]
 name = "degiro_portfolio"
-version = "0.5.4"
+version = "0.5.5"
 description = "DEGIRO portfolio tracking and visualization application"
 readme = "README.md"
 requires-python = ">=3.10"

src/degiro_portfolio/__init__.py

@@ -1,2 +1,2 @@
 """Stock price visualization application."""
-__version__ = "0.5.4"
+__version__ = "0.5.5"

src/degiro_portfolio/main.py

@@ -84,7 +84,7 @@ def ensure_indices_exist(db: Session) -> tuple[int, int]:
     return indices_created, prices_fetched
 
 
-app = FastAPI(title="DEGIRO Portfolio", version="0.4.0")
+app = FastAPI(title="DEGIRO Portfolio", version="0.5.5")
 
 # Track server start time
 SERVER_START_TIME = datetime.now()
@@ -97,7 +97,7 @@ async def startup_event():
 
 
 @app.get("/api/ping")
-async def ping():
+def ping():
     """Health check endpoint returning server name and uptime."""
     uptime_seconds = (datetime.now() - SERVER_START_TIME).total_seconds()
 
@@ -168,14 +168,14 @@ def to_dict(self):
 
 
 @app.get("/")
-async def root():
+def root():
     """Serve the main page."""
     index_path = os.path.join(os.path.dirname(__file__), "static", "index.html")
     return FileResponse(index_path)
 
 
 @app.get("/api/holdings")
-async def get_holdings(db: Session = Depends(get_db)):
+def get_holdings(db: Session = Depends(get_db)):
     """Get all current stock holdings.
 
     Optimized to use bulk queries instead of N+1 pattern.
@@ -283,7 +283,7 @@ async def get_holdings(db: Session = Depends(get_db)):
 
 
 @app.get("/api/market-data-status")
-async def get_market_data_status(db: Session = Depends(get_db)):
+def get_market_data_status(db: Session = Depends(get_db)):
     """Get the most recent market data date."""
     # Get most recent price date across all stocks
     latest_price = db.query(StockPrice).order_by(StockPrice.date.desc()).first()
@@ -301,7 +301,7 @@ async def get_market_data_status(db: Session = Depends(get_db)):
 
 
 @app.get("/api/exchange-rates")
-async def get_exchange_rates(db: Session = Depends(get_db)):
+def get_exchange_rates(db: Session = Depends(get_db)):
     """Get current exchange rates for currency conversion.
 
     Uses cached rates from the database if available for today.
@@ -384,7 +384,7 @@ def _get_fallback_rate(currency: str) -> float:
 
 
 @app.get("/api/stock/{stock_id}/prices")
-async def get_stock_prices(stock_id: int, db: Session = Depends(get_db)):
+def get_stock_prices(stock_id: int, db: Session = Depends(get_db)):
     """Get historical prices for a stock."""
     stock = db.query(Stock).filter(Stock.id == stock_id).first()
     if not stock:
@@ -415,7 +415,7 @@ async def get_stock_prices(stock_id: int, db: Session = Depends(get_db)):
 
 
 @app.get("/api/stock/{stock_id}/transactions")
-async def get_stock_transactions(stock_id: int, db: Session = Depends(get_db)):
+def get_stock_transactions(stock_id: int, db: Session = Depends(get_db)):
     """Get transaction history for a stock."""
     stock = db.query(Stock).filter(Stock.id == stock_id).first()
     if not stock:
@@ -447,7 +447,7 @@ async def get_stock_transactions(stock_id: int, db: Session = Depends(get_db)):
 
 
 @app.get("/api/stock/{stock_id}/chart-data")
-async def get_chart_data(stock_id: int, db: Session = Depends(get_db)):
+def get_chart_data(stock_id: int, db: Session = Depends(get_db)):
     """Get chart data for a stock including prices and transactions."""
     stock = db.query(Stock).filter(Stock.id == stock_id).first()
     if not stock:
@@ -616,7 +616,7 @@ async def get_chart_data(stock_id: int, db: Session = Depends(get_db)):
 
 
 @app.get("/api/portfolio-summary")
-async def get_portfolio_summary(db: Session = Depends(get_db)):
+def get_portfolio_summary(db: Session = Depends(get_db)):
     """Compute portfolio summary in a single server-side call.
 
     Returns total holdings count, net invested, current value, and gain/loss.
@@ -698,7 +698,7 @@ async def get_portfolio_summary(db: Session = Depends(get_db)):
 
 
 @app.get("/api/portfolio-performance")
-async def get_portfolio_performance(db: Session = Depends(get_db)):
+def get_portfolio_performance(db: Session = Depends(get_db)):
     """Get percentage return performance for all currently held stocks.
 
     Optimized to fetch all data in bulk queries.
@@ -776,7 +776,7 @@ async def get_portfolio_performance(db: Session = Depends(get_db)):
 
 
 @app.get("/api/portfolio-valuation-history")
-async def get_portfolio_valuation_history(db: Session = Depends(get_db)):
+def get_portfolio_valuation_history(db: Session = Depends(get_db)):
     """
     Get historical portfolio valuation over time.
     Returns dates, net invested capital (buys - sells), and portfolio values (all in EUR).
@@ -1180,7 +1180,7 @@ def determine_native_currency(df_data, product):
 
 
 @app.post("/api/refresh-live-prices")
-async def refresh_live_prices(db: Session = Depends(get_db)):
+def refresh_live_prices(db: Session = Depends(get_db)):
     """Fetch real-time price quotes for currently held stocks using Twelve Data or Yahoo Finance.
 
     Optimized to use bulk query for holdings calculation.
@@ -1303,7 +1303,7 @@ async def refresh_live_prices(db: Session = Depends(get_db)):
 
 
 @app.post("/api/update-market-data")
-async def update_market_data(db: Session = Depends(get_db)):
+def update_market_data(db: Session = Depends(get_db)):
     """Fetch latest market data for currently held stocks and indices.
 
     Optimized to use bulk query for holdings calculation.
@@ -1459,7 +1459,7 @@ async def update_market_data(db: Session = Depends(get_db)):
 
 
 @app.post("/api/purge-database")
-async def purge_database(db: Session = Depends(get_db)):
+def purge_database(db: Session = Depends(get_db)):
     """Purge all data from the database (stocks, transactions, prices, indices).
 
     WARNING: This is a destructive operation that cannot be undone!
@@ -1512,7 +1512,7 @@ async def purge_database(db: Session = Depends(get_db)):
 
 
 @app.post("/api/shutdown")
-async def shutdown():
+def shutdown():
     """Shut down the server (used by desktop mode when the window closes)."""
     import threading as _threading
     if _shutdown_event is not None:

tests/conftest.py

@@ -409,7 +409,11 @@ def base_url(server_process):
 def shared_page(context: BrowserContext, server_process):
     """Create a page shared across tests in a module (for read-only tests)."""
     page = context.new_page()
-    page.goto(server_process, timeout=30000)
+    # wait_until='domcontentloaded' avoids blocking on background fetch() calls
+    # (e.g. /api/exchange-rates, /api/portfolio-valuation-history) that the
+    # frontend fires on load. Those can take seconds against the real subprocess
+    # server under parallel load — we only need the DOM ready to start asserting.
+    page.goto(server_process, timeout=30000, wait_until="domcontentloaded")
     yield page
     page.close()
 
@@ -418,9 +422,9 @@ def shared_page(context: BrowserContext, server_process):
 def page(shared_page, server_process):
     """Provide page for each test, navigating back to home to reset state."""
     # Navigate back to home page to reset state between tests
-    shared_page.goto(server_process, timeout=30000)
+    shared_page.goto(server_process, timeout=30000, wait_until="domcontentloaded")
     # Wait for page to be fully loaded (holdings to appear)
-    shared_page.wait_for_selector(".stock-card", timeout=8000)  # 8 seconds
+    shared_page.wait_for_selector(".stock-card", timeout=15000)
     yield shared_page
 
 

tests/test_e2e_csv_import.py

@@ -176,7 +176,7 @@ def mock_api_response(route):
 def csv_page(csv_context, csv_server):
     """Page navigated to the server after CSV has been uploaded."""
     page = csv_context.new_page()
-    page.goto(csv_server, timeout=10000)
+    page.goto(csv_server, timeout=30000, wait_until="domcontentloaded")
     page.wait_for_selector(".stock-card", timeout=15000)
     yield page
     page.close()

tests/test_e2e_dutch_import.py

@@ -123,7 +123,7 @@ def mock_api(route):
 @pytest.fixture(scope="module")
 def dutch_page(dutch_context, dutch_server):
     page = dutch_context.new_page()
-    page.goto(dutch_server, timeout=15000)
+    page.goto(dutch_server, timeout=30000, wait_until="domcontentloaded")
     page.wait_for_selector(".stock-card", timeout=15000)
     yield page
     page.close()