-
-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add git remote task provider #4233
Conversation
@jdx do you know how i can add some unit tests for this part ? ![]() Currently, we can't mock |
I would use e2e tests for this |
@jdx if you want to do a first review, all the code is done, I just have to do the e2e tests |
@jdx All the code is finished and I'm trying to add some e2e tests but I'm having trouble with them 😅 if you have an idea how to implement them correcly |
hmm I don't know what it means:
it might be a bug in the git code that isn't correctly creating the repo or something. If I get some time next week I'll see if I can dive in but I don't think this is a test issue so much as an issue with the code. |
Dont worry I found why, that why I want to add the clone options behavior to your git library, when it will be merged on main I will fix the issue in my pr 👍 |
@jdx should i use the crate::git or https://github.com/jdx/xx to clone repositories in this PR ? |
@jdx i have fixed all the tests but to be able to pass e2e ssh tests with github action i need to add a ssh key This block of code cannot works because - uses: shimataro/ssh-key-action@v2
with:
key: ${{ secrets.RTX_SSH_KEY }} Can you do something for me ? |
you won't be able to use secrets in CI at all, is it possible to create one just for the test runs? |
@jdx I tried to create a temporary ssh key (latest commit) but it can't work properly because the key is not saved to any account :( |
Should we indicate the I wonder if things like |
I think long term you should be able to use the |
### 🚀 Features - **(registry)** add jd by [@risu729](https://github.com/risu729) in [#4318](#4318) - **(registry)** add jc by [@risu729](https://github.com/risu729) in [#4317](#4317) - **(registry)** Add qsv cli by [@vjda](https://github.com/vjda) in [#4334](#4334) - add support for idiomatic go.mod file by [@roele](https://github.com/roele) in [#4312](#4312) - add -g short version for unuse cmd by [@kimle](https://github.com/kimle) in [#4330](#4330) - add git remote task provider by [@acesyde](https://github.com/acesyde) in [#4233](#4233) - set usage arguments and flags as environment variables for toml tasks by [@gturi](https://github.com/gturi) in [#4159](#4159) ### 🐛 Bug Fixes - **(aqua)** trim prefix before comparing versions by [@risu729](https://github.com/risu729) in [#4340](#4340) - wrong config file type for rust-toolchain.toml files by [@roele](https://github.com/roele) in [#4321](#4321) ### 🚜 Refactor - **(registry)** use aqua for yq by [@scop](https://github.com/scop) in [#4326](#4326) ### 📚 Documentation - **(schema)** fix description of task.dir default by [@risu729](https://github.com/risu729) in [#4324](#4324) - Add PowerShell example by [@jahanson](https://github.com/jahanson) in [#3857](#3857) - Include "A Mise guide for Swift developers" by [@pepicrft](https://github.com/pepicrft) in [#4329](#4329) - Update documentation for core tools by [@hverlin](https://github.com/hverlin) in [#4341](#4341) - Update vitepress to fix search by [@hverlin](https://github.com/hverlin) in [#4342](#4342) ### Chore - **(bun.lock)** migrate bun lockfiles to text-based by [@risu729](https://github.com/risu729) in [#4319](#4319) ### New Contributors - @vjda made their first contribution in [#4334](#4334) - @kimle made their first contribution in [#4330](#4330) - @pepicrft made their first contribution in [#4329](#4329) - @jahanson made their first contribution in [#3857](#3857)
Description
Add a git remote task provider
This provider handle ssh and https generic format
Specific patterns like github or bitbucket are not translated because the ROI is too low and add useless complex code.
User must define a generic url with path