Fix audio track not persisting across episode transitions#5326
Open
skalthoff wants to merge 2 commits intojellyfin:masterfrom
Open
Fix audio track not persisting across episode transitions#5326skalthoff wants to merge 2 commits intojellyfin:masterfrom
skalthoff wants to merge 2 commits intojellyfin:masterfrom
Conversation
When transitioning to the next episode, the user's audio track selection was being reset because startItem() was clearing audioStreamIndex after buildExoPlayerOptions() had already set it from the stored language preference. This removes the unnecessary reset, allowing the language preference (stored via lastPlayedAudioLanguageIsoCode) to persist correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Removed an unnecessary reset of audioStreamIndex in startItem() that was overriding the language preference already set by buildExoPlayerOptions(). The existing mechanism that stores the user's audio language was working correctly—it was just being immediately undone.
Code assistance
Debugging guidance to trace the audio preference flow and identify where it was being reset.
Issues