Feature - add program info toggle button to playback overlay#5432
Open
WizardOfYendor1 wants to merge 2 commits intojellyfin:masterfrom
Open
Feature - add program info toggle button to playback overlay#5432WizardOfYendor1 wants to merge 2 commits intojellyfin:masterfrom
WizardOfYendor1 wants to merge 2 commits intojellyfin:masterfrom
Conversation
WizardOfYendor1
changed the title
Add an "i" button to the transport control bar when watching live TV. Pressing it expands the top panel to show the current program's metadata (info row with ratings, episode info, time range) and description. Also fix back button behavior so pressing back while the overlay is visible just dismisses the overlay instead of exiting playback.
…ll media types (not just live tv).
WizardOfYendor1
force-pushed
the
feature/program-info-overlay
branch
from
8022e4d to
4f4434b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an "i" button in the "secondary" actions on the overlay (aka bottom half) on the right, that toggles overlay display of the current in progress program info on the screen.
Changes
Added new program info supporting classes, action handling and top bar sizing change to accommodate program info data.
Code assistance
Used sonnet 4.6 for code review, made a few changes/optimisations based upon that review.