Fix playback not resuming after seek/skip operations#5462
Open
tvinhas wants to merge 2 commits intojellyfin:masterfrom
Open
Fix playback not resuming after seek/skip operations#5462tvinhas wants to merge 2 commits intojellyfin:masterfrom
tvinhas wants to merge 2 commits intojellyfin:masterfrom
Conversation
DPAD_RIGHT/LEFT now directly trigger skip forward/back instead of only
showing the transport overlay, which previously required the leanback
seekbar's pause-preview-confirm flow to complete a seek.
Additional seek state management fixes:
- Guard progress loop during seek to prevent onIsPlayingChanged(false)
from killing it during ExoPlayer buffering
- Add onSeekComplete callback to detect seek completion via both
STATE_READY and onIsPlayingChanged(true)
- Remove blocking wasSeeking guard that prevented subsequent seeks
- Reset mSeekPosition in onSeekComplete to avoid stale position reads
- Add 8-second seek timeout safety net
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
DPAD_RIGHT/LEFT now directly trigger skip forward/back instead of only
showing the transport overlay, which previously required the leanback
seekbar's pause-preview-confirm flow to complete a seek.
Additional seek state management fixes: