Open
Conversation
Member
Author
|
If you want to test, this branch is all configured ready to go. Currently pointed at my branch until we have our next release: |
Updating the README to include the ServerDiscovery class.
Cleaner documentation
Member
Author
|
I think it would make sense to knock out #46 before this one. I'm happy where this one stands but I was able to do this same network discovery using If we end up using my current version of the WebSocket where I don't use NIO, it would make more sense to me to redo this one but using non-NIO to avoid adding the dependency unnecessarily. If we decide we want to use NIO for the WebSocket, we can keep this as-is but I think WebSocket should dictate NIO instead of this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Per: jellyfin/Swiftfin#1533
Moves the
ServerDiscoverylogic into the SDK instead of being in Swiftfin. Introduces a new dependency for the SDK in:https://github.com/apple/swift-nio-transport-services
Questions
getfunc and ifaddr. The downside of manually getting the IP is we only broadcast on one IP instead of binding to all interfaces. I would prefer we take the 0.0.0.0 & :: route instead of using thesegetfuncs since that gives us a more robust approach and reduces the total code for this PR. The current version of this uses thegetfuncs but I'd be happy to change this if we are fine with those errors getting logged.print()the same messages to the terminal. I was considering os.log but I saw that required a version bump for MacOS. Whatever approach we want I can make changes. The log prints aren't necessary so worst case I can just delete all the prints.