Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manifest v3 compatibility #73

Draft
wants to merge 32 commits into
base: main
Choose a base branch
from
Draft

Manifest v3 compatibility #73

wants to merge 32 commits into from

Conversation

jelmervdl
Copy link
Owner

@jelmervdl jelmervdl commented Jul 19, 2023

Use manifest v3 for Firefox, and Chrome.

In Chrome, we use chrome.offscreen to have access to Worker. Unfortunately, that means yet another layer of indirection: Translations now go from the page -> content-script -> background-script -> offscreen script -> worker -> wasm runtime 😭

Todo:

  • Restore tab state when the service worker is unloaded
  • Communicate translation cancellation to worker in the Offscreen page: problem is that AbortSignal doesn't make it across the message passing boundary.

What I'd really really like:

  • Tests! I can't keep testing two browsers manually :(

@jelmervdl jelmervdl linked an issue Jul 19, 2023 that may be closed by this pull request
@jelmervdl
Copy link
Owner Author

For some reason you need to enable the access to statmt and translatelocally explicitly. Quite annoying. I wonder if that's something missing in the installation flow because I'm running in developer mode or not.

Screenshot 2023-07-19 at 14 15 40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Google Chrome
1 participant