Jmpi add matching rule to audit trail #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @NyashaMuusha . Could you update your branch with |
…le-to-audit-trail
walisc
requested changes
Feb 23, 2024
walisc
requested changes
Feb 26, 2024
JeMPI_Apps/JeMPI_LibMPI/src/main/java/org/jembi/jempi/libmpi/LibMPI.java
Outdated
Show resolved
Hide resolved
JeMPI_Apps/JeMPI_Bootstrapper/src/main/resources/data/postgres/audit-schema.sql
Outdated
Show resolved
Hide resolved
JeMPI_Apps/JeMPI_LibShared/src/main/java/org/jembi/jempi/shared/models/ApiModels.java
Outdated
Show resolved
Hide resolved
…ule-to-audit-trail' into JMPI-add-matching-rule-to-audit-trail
walisc
requested changes
Mar 4, 2024
JeMPI_Apps/JeMPI_Bootstrapper/src/main/resources/data/postgres/audit-schema.sql
Outdated
Show resolved
Hide resolved
JeMPI_Apps/JeMPI_LibMPI/src/main/java/org/jembi/jempi/libmpi/LibMPI.java
Show resolved
Hide resolved
…d audit event method
…trail' into JMPI-add-matching-rule-to-audit-trail # Conflicts: # JeMPI_Apps/JeMPI_Controller/src/main/java/org/jembi/jempi/controller/PsqlAuditTrail.java
…trail' into JMPI-add-matching-rule-to-audit-trail # Conflicts: # JeMPI_Apps/JeMPI_LibAPI/src/main/java/org/jembi/jempi/libapi/Routes.java
…trail' into JMPI-add-matching-rule-to-audit-trail
…trail' into JMPI-add-matching-rule-to-audit-trail # Conflicts: # JeMPI_Apps/JeMPI_LibShared/src/main/java/org/jembi/jempi/shared/models/ApiModels.java
walisc
requested changes
Mar 13, 2024
| goldenID VARCHAR(64), | ||
| event VARCHAR(256), | ||
| eventType VARCHAR(256), | ||
| eventData TEXT, |
There was a problem hiding this comment.
Could we JSONB here, and filter as appropriate below. In JeMPI_Apps/JeMPI_LibAPI/src/main/java/org/jembi/jempi/libapi/PsqlAuditTrail.java
| import static org.jembi.jempi.shared.utils.AppUtils.OBJECT_MAPPER; | ||
|
|
||
|
|
||
| public final class AuditTrailUtil { |
There was a problem hiding this comment.
Could you rename this to something like AuditTrailBridge as Util classes don't usually get instantiated
walisc
approved these changes
Mar 14, 2024
|
p.s you just need to pull |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Description of changes
Modified database audit event to store event type and event data to make it more generic and reusable
De-serialized data based on event type
Calculated linking rule from golden record and interaction record and added value to audit event
Modified API response for audit trail to reflect new changes
Added matching type column on audit trail table in UI
2. How to test/configure
Navigate to http://localhost:3000/browse-records
Double click on a record