Cu 86bzhmv6z custom aux gid not accepted during golden record creation or restoration #273
Conversation
WalkthroughRecent updates affect various components across the JeMPI application. The Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (5)
- JeMPI_Apps/JeMPI_EM_Scala/src/main/scala/org/jembi/jempi/em/config/Config.scala (2 hunks)
- JeMPI_Apps/JeMPI_LibShared/src/main/java/org/jembi/jempi/shared/config/input/Generate.java (1 hunks)
- JeMPI_Apps/JeMPI_LibShared/src/main/java/org/jembi/jempi/shared/models/AuxGoldenRecordData.java (2 hunks)
- JeMPI_Apps/JeMPI_LibShared/src/main/java/org/jembi/jempi/shared/utils/AppUtils.java (3 hunks)
- devops/linux/docker/data-config/config-reference-link-dp.json (2 hunks)
Additional comments not posted (7)
JeMPI_Apps/JeMPI_LibShared/src/main/java/org/jembi/jempi/shared/config/input/Generate.java (2)
6-8: LGTM! New field added toGeneraterecord.The
interactionFieldfield has been correctly added to theGeneraterecord.
10-12: LGTM! New constructor added to initializeinteractionField.The new constructor correctly initializes the
interactionFieldfield tonullif not provided.JeMPI_Apps/JeMPI_EM_Scala/src/main/scala/org/jembi/jempi/em/config/Config.scala (1)
39-42: LGTM! New field added toGeneratecase class.The
interactionFieldfield has been correctly added to theGeneratecase class with a default value ofNone.JeMPI_Apps/JeMPI_LibShared/src/main/java/org/jembi/jempi/shared/utils/AppUtils.java (1)
55-76: LGTM! New methoddefaultIfFalsyadded.The method correctly handles default values for various types by returning a default value if the input is considered falsy.
JeMPI_Apps/JeMPI_LibShared/src/main/java/org/jembi/jempi/shared/models/AuxGoldenRecordData.java (1)
Line range hint
31-51:
LGTM! Constructor refined to handleinteractionFieldconditions.The changes ensure that the
interactionFieldis correctly handled and the appropriate value is assigned.devops/linux/docker/data-config/config-reference-link-dp.json (2)
29-37: Addition ofaux_gidtoauxInteractionFieldslooks good.A new field
aux_gidwith typeStringand a generation functionAppUtils::autoGenerateIdhas been added. This addition is consistent with other fields using the same generation function.
62-63: Modification ofaux_idand addition ofaux_gidtoauxGoldenRecordFieldslooks good.The existing field
aux_idis updated to include aninteractionFieldproperty referencingaux_gid. A new fieldaux_gidwith typeStringand a generation functionAppUtils::autoGenerateIdhas been added. These changes are consistent with the PR objectives and context.
|
This change is no longer required |
@MatthewErispe I think the logic needs a sanity check. Do you see any potential knock-on effects of the change to the java and scala "Generate" inputs? Seems safe from what I see.
And this "interactionField" argument added to the "generate" prop:
{ "fieldName": "aux_gid", "fieldType": "String", "source": { "generate": { "func": "AppUtils::autoGenerateId", **"interactionField": "aux_gid"** } } }We could make this more generic, like an "args" object, if the future scope of "generate > func" is likely to expand? Could introduce type safety issues doing it that way so just checking what you think...
Summary by CodeRabbit
New Features
interactionFieldin various components for enhanced field mapping and data population logic.defaultIfFalsymethod for handling default values in utilities.Refactor
AuxGoldenRecordDatato handle new interaction field conditions.Chores