Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

212 partial log output #214

Merged
merged 3 commits into from
Jan 11, 2021
Merged

Conversation

tszmytka
Copy link
Collaborator

@tszmytka tszmytka commented Jan 2, 2021

Fixes #212

@tszmytka tszmytka added the bugfix (release-drafter) label Jan 2, 2021
@AvihayTsayeg
Copy link

AvihayTsayeg commented Jan 3, 2021

Hi @tszmytka ,
first would like to thank u for quick response and fixing, I have tested your fix, it do fix the echo example I have added, but it did not fix the build which due I opened the issue.

OK:
image

Still not working:
image

@tszmytka
Copy link
Collaborator Author

@AvihayTsayeg Please provide the script that causes the problem in the original issue.
This PR fixes a valid bug even if it isn't your bug.

@tszmytka tszmytka requested a review from dblock January 11, 2021 08:03
@dblock
Copy link
Member

dblock commented Jan 11, 2021

I'll merge this cause it does look like an issue, and thanks for fixing it @tszmytka!

Consider beefing up tests with empty lines. I am always worried about those index calculations ;)

@dblock dblock merged commit 9b3952a into jenkinsci:master Jan 11, 2021
@avihaycloudinary
Copy link

@dblock
Many thanks, I will add more details.
Thank u @tszmytka

@AvihayTsayeg
Copy link

see #216

@timja
Copy link
Member

timja commented Jan 18, 2021

I think this may have caused tests to break for this plugin on the latest LTS,

See jenkinsci/bom#402

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix (release-drafter)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logs not showing colors
5 participants