[JENKINS-74913] Allow extension point in bitbucket source plugin to provide a implementation for web-hooks management #1061
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfalco79
force-pushed
the
feature/JENKINS-74913
branch
2 times, most recently
from
4981e8f to
a90ddbd
Compare
nfalco79
force-pushed
the
feature/JENKINS-74913
branch
3 times, most recently
from
87759dc to
b75fa8d
Compare
nfalco79
force-pushed
the
feature/JENKINS-74913
branch
2 times, most recently
from
c4adf2d to
695fb85
Compare
nfalco79
commented
Jul 5, 2025
src/main/java/com/cloudbees/jenkins/plugins/bitbucket/api/hook/BitbucketHookProcessor.java
Outdated
Show resolved
Hide resolved
nfalco79
force-pushed
the
feature/JENKINS-74913
branch
7 times, most recently
from
f34291b to
ef896c0
Compare
nfalco79
force-pushed
the
feature/JENKINS-74913
branch
from
ef896c0 to
26b9cb9
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -314,7 +237,7 @@ | |||
| * @param value the URL to check. | |||
| * @return the validation results. | |||
| */ | |||
| public static FormValidation doCheckServerUrl(@QueryParameter String value) { | |||
| public static FormValidation doCheckServerURL(@QueryParameter String value) { | |||
Check warning
Code scanning / Jenkins Security Scan
Stapler: Missing POST/RequirePOST annotation Warning
| @@ -314,7 +237,7 @@ | |||
| * @param value the URL to check. | |||
| * @return the validation results. | |||
| */ | |||
| public static FormValidation doCheckServerUrl(@QueryParameter String value) { | |||
| public static FormValidation doCheckServerURL(@QueryParameter String value) { | |||
Check warning
Code scanning / Jenkins Security Scan
Stapler: Missing permission check Warning
| if (getBitbucketJenkinsRootUrl() != null) { | ||
| setBitbucketJenkinsRootUrl(getBitbucketJenkinsRootUrl()); | ||
| @RequirePOST | ||
| public Collection<? extends Descriptor<?>> getWebhookDescriptors() { |
Check warning
Code scanning / Jenkins Security Scan
Stapler: Missing permission check Warning
| @@ -323,6 +222,14 @@ | |||
| return FormValidation.ok(); | |||
| } | |||
|
|
|||
| @RequirePOST | |||
| public Collection<? extends Descriptor<?>> getWebhookDescriptors() { | |||
Check warning
Code scanning / Jenkins Security Scan
Stapler: Missing permission check Warning
nfalco79
force-pushed
the
feature/JENKINS-74913
branch
2 times, most recently
from
7e9f003 to
7370183
Compare
…rovide a implementation for web-hooks management WIP refactor the webhook registration, I should create yet another interface that melt global configuration trait configurations, SCMOwner information (repository name and owner) and use a authenticated client to perform calls. Fix CasC configuration change UI make readResolve compatible with old format Add webhook extensible interface to provide custom implementation of wehbook from configuration to the APIs to register it on Bitbucket Add extension point interface to register hook processor provided by other plugins Remove manage of hook events that does ship any king of changes in the source code like reviewer changed or PR approved, they was used only to trigger builds if that kind of changes was enabled bitbucket side. Reindex on empty changes has been turn-off by default, this to avoid scan all repositories if not required.
nfalco79
force-pushed
the
feature/JENKINS-74913
branch
from
7370183 to
ae6585c
Compare
…rovide a implementation for web-hooks management new interface to apply a webhook configuration to the Bitbucket
nfalco79
force-pushed
the
feature/JENKINS-74913
branch
from
ae6585c to
e20e512
Compare
…rovide a implementation for web-hooks management new interface to apply a webhook configuration to the Bitbucket
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add extension point interface to register hook processor provided by other plugins
Remove management of hook events that does ship any king of changes in the source code like reviewer changed or PR approved, they was used only to trigger builds if that kind of event was enabled in bitbucket manually.
Reindex on empty changes has been turn-off by default, this to avoid scan all repositories if not required.
WIP