Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default behavior to truncate Checks text from start when maxSize present #270

Merged
merged 3 commits into from
Feb 5, 2025

Conversation

sarahdeitke
Copy link
Contributor

From these two tickets:

jenkinsci/github-checks-plugin#343 (comment)
jenkinsci/github-checks-plugin#423

We believe it is better to default truncating the checks text default behavior to be from the start rather than the end of the logs. This behavior is better because typically the most relevant logs, especially error logs, happen at the end of the output.

Testing done

Added two unit tests to cover the change, ensured that the unit tests passed
Screenshot 2025-02-04 at 3 51 34 PM

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@timja timja added the enhancement New feature or request label Feb 5, 2025
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Not tested manually but the unit test and by my reading of TruncatedString it looks good.

@timja timja merged commit 1a9685d into jenkinsci:master Feb 5, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants