Restore compatibility with Credentials Binding Plugin after SECURITY-698 #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpederzolli
changed the title
|
FYI @jonhermansen, this resolves a security issue with passwords (with a |
|
Hey @jpederzolli, thank you for the patch! I would like to merge this ASAP but I want to go through some manual testing myself first. I'll try to get it merged/released this weekend. |
|
@jonhermansen sounds good, thanks! |
|
Any word on this change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves an issue using the credentials binding plugin and a credential with a
$in it.Specifically, this change jenkinsci/credentials-binding-plugin@0c75238#diff-c4de7f03a70e0d1a7b7e4153c45cfcb9R101 converts a single
$into$$$$-- resulting in the container process seeing$$instead of a single$. This PR results in the correct credentials being passed to the container build.Additionally, logic was added to mask sensitive variables since they will not be masked (completely) if the credential contains one or more
$characters.