Skip to content

ASG warm pool support#519

Open
VSilantyev wants to merge 2 commits intojenkinsci:masterfrom
VSilantyev:feature/warm-pool
Open

ASG warm pool support#519
VSilantyev wants to merge 2 commits intojenkinsci:masterfrom
VSilantyev:feature/warm-pool

Conversation

@VSilantyev
Copy link

The idea behind this PR is to allow ASG to use warm pool, for faster builds - it's faster to get stopped instance from warm pool, than spin up it from image, and stopped instance will have caches/checked out code from last build.

Implementation details:
Instead of terminating instance - plugin removes scale-in protection from the instance it wants to terminate and allows ASG to handle instance termination - AGS will move this instance back to warm pool if there is one configured.

Related to #352

Testing done

Tested on live jenkins instance, and corrected automated tests.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests that demonstrate the feature works or the issue is fixed

…SG - remove scale-in protection and allow ASG to terminate them or move them to warm pool.
@VSilantyev VSilantyev requested a review from a team as a code owner February 4, 2026 04:55
@BradyShober
Copy link
Contributor

This change breaks the use case of configuring a maximum number of builds. When an instance reaches the maximum number of builds, the desired capacity may not change, but the plugin will set the instance offline within Jenkins then execute the termination. If the plugin is changed to no longer issue terminations, then those instances would never be replaced and just sit idle not able to process any jobs.

@VSilantyev
Copy link
Author

Added logic - terminate if max uses exhausted, remove scale in protection otherwise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants