Skip to content

Conversation

@NotMyFault
Copy link
Member

What does this PR do?

Starting with helm 3, you can provide a schema for your values.
The change proposed adds an action to do so upon PRs or request.

  • Fixes #

If you modified files in the ./charts/jenkins/ directory, please also include the following:

### Submitter checklist
- [x] I bumped the "version" key in `./charts/jenkins/Chart.yaml`.
- [x] I added a new changelog entry to `./charts/jenkins/CHANGELOG.md`.
- [x] I followed the [technical requirements](https://github.com/jenkinsci/helm-charts/blob/main/CONTRIBUTING.md#technical-requirements).
- [x] I ran `.github/helm-docs.sh` from the project root.

Special notes for your reviewer

@NotMyFault NotMyFault requested review from a team as code owners February 16, 2025 13:07
id: "https://charts.jenkins.io/values.schema.json"
title: "Jenkins Helm Chart"
description: "Values schema for Jenkins Helm Chart"
fail-on-diff: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this fails the build if its out of date?

What's the expected workflow?

If a developer is supposed to run something then:

  1. Needs update to https://github.com/jenkinsci/helm-charts/blob/main/CONTRIBUTING.md
  2. Update to PR template

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants