[JENKINS-50777] Expose SCMRevisionAction and associated metadata via Stapler export #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jglick
commented
Apr 12, 2018
| @@ -43,6 +45,7 @@ | |||
| * | |||
| * @since 2.2.0 | |||
| */ | |||
| @ExportedBean | |||
There was a problem hiding this comment.
Note that #35 exported SCMHead.origin yet neglected to add this annotation, causing
org.kohsuke.stapler.export.NotExportableException: class jenkins.scm.api.SCMHeadOrigin$Fork doesn't have @ExportedBean
This was referenced Apr 12, 2018
abayer
approved these changes
Apr 13, 2018
rsandell
approved these changes
Apr 17, 2018
stephenc
approved these changes
Apr 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JENKINS-50777
Example output with jenkinsci/git-plugin#581 + jenkinsci/github-branch-source-plugin#180 on a
masterbuild:{ "_class" : "jenkins.scm.api.SCMRevisionAction", "revision" : { "_class" : "jenkins.plugins.git.AbstractGitSCMSource$SCMRevisionImpl", "deterministic" : true, "head" : { "_class" : "org.jenkinsci.plugins.github_branch_source.BranchSCMHead", "name" : "master", "origin" : { "_class" : "jenkins.scm.api.SCMHeadOrigin$Default" } }, "hash" : "c9e8148ede406f8ad89610befbdf51ba4a0ef24a" } }and on a PR merge build, specifically cloudbeers/PR-demo#20:
{ "_class" : "jenkins.scm.api.SCMRevisionAction", "revision" : { "_class" : "org.jenkinsci.plugins.github_branch_source.PullRequestSCMRevision", "deterministic" : true, "head" : { "_class" : "org.jenkinsci.plugins.github_branch_source.PullRequestSCMHead", "name" : "PR-20", "origin" : { "_class" : "jenkins.scm.api.SCMHeadOrigin$Fork", "name" : "vivek" } }, "merge" : true, "target" : { "_class" : "jenkins.plugins.git.AbstractGitSCMSource$SCMRevisionImpl", "deterministic" : true, "head" : { "_class" : "org.jenkinsci.plugins.github_branch_source.BranchSCMHead", "name" : "master", "origin" : { "_class" : "jenkins.scm.api.SCMHeadOrigin$Default" } }, "hash" : "c9e8148ede406f8ad89610befbdf51ba4a0ef24a" }, "pullHash" : "5d2f682bc7a77f253e9b887536fa08f7ba41af64" } }Example of extracting important fields from a build URL: