Make some settings optional in pipelines #119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The part that moves fields into |
proski
force-pushed
the
optional-settings
branch
from
594f945 to
eadd996
Compare
jakub-bochenski
approved these changes
Jul 12, 2019
Change the constructor to accept essential settings only. Reorder private fields, setters and getters the way they are ordered in config.jelly.
proski
force-pushed
the
optional-settings
branch
3 times, most recently
from
729a636 to
61284bd
Compare
That makes the Pipeline Snippet Generator skip arguments from the trigger call if those arguments have default values. Keep default values for the skip phrase and the build phrase in the descriptor, so they can be used both in config.jelly and in the code.
proski
force-pushed
the
optional-settings
branch
from
61284bd to
48609f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All advanced settings have reasonable defaults so they can be optional settings. Move then from
@DataBoundConstructorto individual setters.Make
StashBuildTriggerinitialize fields to theconfig.jellydefaults. That way, the Pipeline Snippet Generator knows what the defaults are and skips them from the snippets.A nice side effect is having
test this pleaseandNO TESTshared between the code andconfig.jelly.This PR is based on top of #69, as it's untestable without pipeline support.
The changes are based on https://jenkins.io/doc/developer/plugin-development/pipeline-integration/