Fix same params detection (change and test) #77
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ingOnNode() : only filter executingUnitParams `if paramsToCompare.size() > 0` (do same as done for itemParams and avoid extra variable copying)
…ingOnNode() : refactor to fetch itemTaskName once
…ingOnNode() : refactor paramsToCompareSize to calculate it once
…UseForLimit by a comma, not just whitespace (which is not documented, but apparently nobody complained so used it instead)
…e setting in constructor and method
…d of same string in two places
…ToUseForLimit and paramsToCompare that are related to its usecase
…msToCompare() into a clean setter setParamsToCompare()
…d only setParamsToCompare()
… values (repetitive/surrounding separator chars)
…rseParamsToUseForLimit()
…se_paramsToUseForLimit() : honor the ordering of a List type
… testThrottleJob_constructor_should_parse_paramsToUseForLimit()
…uld_parse_paramsToUseForLimit() to look at truncation of whitespace/separators in input
… get) in testThrottleJob_constructor_should_parse_paramsToUseForLimit()
Updated for minor conflicts after jenkinsci#75 was merged
|
Updated for minor conflicts after #75 was merged |
…ARATOR until it is introduced" This reverts commit 1219b1e since the token is introduced in this re-merged codebase.
This was referenced Dec 22, 2020
|
Released in 2.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As @basil asked, here is the potentially problematic subset of #59 that changes the logic of production code but also adds tests for that :)
See also #75 and #76.
Note that due to the split from original PR, there may be minor merge-conflicts vs other pieces.