Rails 5 Support #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will fix #6 |
1 similar comment
|
@jeremyolliver Do you have any guidance on this? We'd love to see this merged soon, so we don't have to rely on a custom fork. Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this pull request fixes Rails 5/Rails 5.1 deprecation warnings. It is tested to be working in my own app using the forked repo, however I haven't been able to get the tests working in the new_relic_ping code base since the dummy app is not Rails 5 compatible.
What do I need to do to get tests working? I'd love to get this merged as we use new_relic_ping in multiple apps (Rails 4 and Rails 5).
Thanks so much! 👍