Skip to content

Commit

Permalink
🤖 Merge PR DefinitelyTyped#69998 bugfix: [facebook-nodejs-business-sd…
Browse files Browse the repository at this point in the history
…k] add delete function types to classes by @rodinhatokay
  • Loading branch information
rodinhatokay authored Jul 8, 2024
1 parent eff7ed8 commit db345b9
Show file tree
Hide file tree
Showing 44 changed files with 58 additions and 44 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,12 @@ import {
InstagramInsightsResult,
AppData,
ExtendedDeviceInfo,
AbstractCrudObject
AbstractCrudObject,
AdSet,
Campaign,
AdsPixel,
AdCreative,
Ad
} from 'facebook-nodejs-business-sdk';
import { FacebookRequestError } from 'facebook-nodejs-business-sdk/src/exceptions';
import TEventRequest from "facebook-nodejs-business-sdk/src/objects/serverside/event-request";
Expand Down Expand Up @@ -138,3 +143,12 @@ export function testAbstractCrudObjectClassConstructor () {
const abstractCrudObject = new AbstractCrudObject();
const abstractCrudObject2 = new AbstractCrudObject('some-id');
}

export function testDeleteFunctionInAbstractCrudObjects(){
const deleteAdSetFunction = new AdSet().delete;
const deleteCampaignFunction = new Campaign().delete;
const deleteAdAccountFunction = new AdAccount().delete;
const deletePixelFunction = new AdsPixel().delete;
const deleteAdCreativeFunction = new AdCreative().delete;
const deleteAdFunction = new Ad().delete;
}
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ export default class AdAsyncRequestSet extends AbstractCrudObject {
on_complete: "ON_COMPLETE";
}>;
getRequests(fields: string[], params?: Record<string, any>, fetchFirstPage?: boolean): Cursor | Promise<Cursor>;
get(fields: string[], params?: Record<string, any>): Promise<AbstractObject>;
delete(fields: string[], params?: Record<string, any>): Promise<AbstractObject>;
get(fields: string[], params?: Record<string, any>): Promise<AdAsyncRequestSet>;
update(fields: string[], params?: Record<string, any>): Promise<AdAsyncRequestSet>;
}
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,6 @@ export default class AdAsyncRequest extends AbstractCrudObject {
user_canceled: "USER_CANCELED";
user_canceled_dependency: "USER_CANCELED_DEPENDENCY";
}>;
get(fields: string[], params?: Record<string, any>): Promise<AbstractObject>;
delete(fields: string[], params?: Record<string, any>): Promise<AbstractObject>;
get(fields: string[], params?: Record<string, any>): Promise<AdAsyncRequest>;
}
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,7 @@ export default class AdCreative extends AbstractCrudObject {
createAdLabel(fields: string[], params?: Record<string, any>, pathOverride?: string | null): Promise<AdCreative>;
getCreativeInsights(fields: string[], params?: Record<string, any>, fetchFirstPage?: boolean): Cursor | Promise<Cursor>;
getPreviews(fields: string[], params?: Record<string, any>, fetchFirstPage?: boolean): Cursor | Promise<Cursor>;
get(fields: string[], params?: Record<string, any>): Promise<AbstractObject>;
delete(fields: string[], params?: Record<string, any>): Promise<AbstractObject>;
get(fields: string[], params?: Record<string, any>): Promise<AdCreative>;
update(fields: string[], params?: Record<string, any>): Promise<AdCreative>;
}
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ export default class AdLabel extends AbstractCrudObject {
getAds(fields: string[], params?: Record<string, any>, fetchFirstPage?: boolean): Cursor | Promise<Cursor>;
getAdSets(fields: string[], params?: Record<string, any>, fetchFirstPage?: boolean): Cursor | Promise<Cursor>;
getCampaigns(fields: string[], params?: Record<string, any>, fetchFirstPage?: boolean): Cursor | Promise<Cursor>;
get(fields: string[], params?: Record<string, any>): Promise<AbstractObject>;
delete(fields: string[], params?: Record<string, any>): Promise<AbstractObject>;
get(fields: string[], params?: Record<string, any>): Promise<AdLabel>;
update(fields: string[], params?: Record<string, any>): Promise<AdLabel>;
}
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ export default class AdRule extends AbstractCrudObject {
createExecute(fields: string[], params?: Record<string, any>, pathOverride?: string | null): Promise<AbstractObject>;
getHistory(fields: string[], params?: Record<string, any>, fetchFirstPage?: boolean): Cursor | Promise<Cursor>;
createPreview(fields: string[], params?: Record<string, any>, pathOverride?: string | null): Promise<AdRule>;
get(fields: string[], params?: Record<string, any>): Promise<AbstractObject>;
delete(fields: string[], params?: Record<string, any>): Promise<AbstractObject>;
get(fields: string[], params?: Record<string, any>): Promise<AdRule>;
update(fields: string[], params?: Record<string, any>): Promise<AdRule>;
}
2 changes: 1 addition & 1 deletion types/facebook-nodejs-business-sdk/src/objects/ad-set.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,7 @@ export default class AdSet extends AbstractCrudObject {
getInsights(fields: string[], params?: Record<string, any>, fetchFirstPage?: boolean): Cursor | Promise<Cursor>;
getInsightsAsync(fields: string[], params?: Record<string, any>, pathOverride?: string | null): Promise<AdReportRun>;
getTargetingSentenceLines(fields: string[], params?: Record<string, any>, fetchFirstPage?: boolean): Cursor | Promise<Cursor>;
get(fields: string[], params?: Record<string, any>): Promise<AbstractObject>;
delete(fields: string[], params?: Record<string, any>): Promise<AbstractObject>;
get(fields: string[], params?: Record<string, any>): Promise<AdSet>;
update(fields: string[], params?: Record<string, any>): Promise<AdSet>;
}
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ export default class AdStudy extends AbstractCrudObject {
getInstances(fields: string[], params?: Record<string, any>, fetchFirstPage?: boolean): Cursor | Promise<Cursor>;
createInstance(fields: string[], params?: Record<string, any>, pathOverride?: string | null): Promise<PrivateLiftStudyInstance>;
getObjectives(fields: string[], params?: Record<string, any>, fetchFirstPage?: boolean): Cursor | Promise<Cursor>;
get(fields: string[], params?: Record<string, any>): Promise<AbstractObject>;
delete(fields: string[], params?: Record<string, any>): Promise<AbstractObject>;
get(fields: string[], params?: Record<string, any>): Promise<AdStudy>;
update(fields: string[], params?: Record<string, any>): Promise<AdStudy>;
}
2 changes: 1 addition & 1 deletion types/facebook-nodejs-business-sdk/src/objects/ad.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ export default class Ad extends AbstractCrudObject {
getLeads(fields: string[], params?: Record<string, any>, fetchFirstPage?: boolean): Cursor | Promise<Cursor>;
getPreviews(fields: string[], params?: Record<string, any>, fetchFirstPage?: boolean): Cursor | Promise<Cursor>;
getTargetingSentenceLines(fields: string[], params?: Record<string, any>, fetchFirstPage?: boolean): Cursor | Promise<Cursor>;
get(fields: string[], params?: Record<string, any>): Promise<AbstractObject>;
delete(fields: string[], params?: Record<string, any>): Promise<AbstractObject>;
get(fields: string[], params?: Record<string, any>): Promise<Ad>;
update(fields: string[], params?: Record<string, any>): Promise<Ad>;
}
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,6 @@ export default class AppRequest extends AbstractCrudObject {
object: "object";
to: "to";
}>;
get(fields: string[], params?: Record<string, any>): Promise<AbstractObject>;
delete(fields: string[], params?: Record<string, any>): Promise<AbstractObject>;
get(fields: string[], params?: Record<string, any>): Promise<AppRequest>;
}
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ export default class BusinessRoleRequest extends AbstractCrudObject {
partner_center_marketing: "PARTNER_CENTER_MARKETING";
partner_center_operations: "PARTNER_CENTER_OPERATIONS";
}>;
get(fields: string[], params?: Record<string, any>): Promise<AbstractObject>;
delete(fields: string[], params?: Record<string, any>): Promise<AbstractObject>;
get(fields: string[], params?: Record<string, any>): Promise<BusinessRoleRequest>;
update(fields: string[], params?: Record<string, any>): Promise<BusinessRoleRequest>;
}
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ export default class BusinessUser extends AbstractCrudObject {
getAssignedBusinessAssetGroups(fields: string[], params?: Record<string, any>, fetchFirstPage?: boolean): Cursor | Promise<Cursor>;
getAssignedPages(fields: string[], params?: Record<string, any>, fetchFirstPage?: boolean): Cursor | Promise<Cursor>;
getAssignedProductCatalogs(fields: string[], params?: Record<string, any>, fetchFirstPage?: boolean): Cursor | Promise<Cursor>;
get(fields: string[], params?: Record<string, any>): Promise<AbstractObject>;
delete(fields: string[], params?: Record<string, any>): Promise<AbstractObject>;
get(fields: string[], params?: Record<string, any>): Promise<BusinessUser>;
update(fields: string[], params?: Record<string, any>): Promise<BusinessUser>;
}
Original file line number Diff line number Diff line change
Expand Up @@ -417,7 +417,7 @@ export default class Campaign extends AbstractCrudObject {
createCopy(fields: string[], params?: Record<string, any>, pathOverride?: string | null): Promise<Campaign>;
getInsights(fields: string[], params?: Record<string, any>, fetchFirstPage?: boolean): Cursor | Promise<Cursor>;
getInsightsAsync(fields: string[], params?: Record<string, any>, pathOverride?: string | null): Promise<AdReportRun>;
get(fields: string[], params?: Record<string, any>): Promise<AbstractObject>;
delete(fields: string[], params?: Record<string, any>): Promise<AbstractObject>;
get(fields: string[], params?: Record<string, any>): Promise<Campaign>;
update(fields: string[], params?: Record<string, any>): Promise<Campaign>;
}
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ export default class Comment extends AbstractCrudObject {
getLikes(fields: string[], params?: Record<string, any>, fetchFirstPage?: boolean): Cursor | Promise<Cursor>;
createLike(fields: string[], params?: Record<string, any>, pathOverride?: string | null): Promise<Comment>;
getReactions(fields: string[], params?: Record<string, any>, fetchFirstPage?: boolean): Cursor | Promise<Cursor>;
get(fields: string[], params?: Record<string, any>): Promise<AbstractObject>;
delete(fields: string[], params?: Record<string, any>): Promise<AbstractObject>;
get(fields: string[], params?: Record<string, any>): Promise<Comment>;
update(fields: string[], params?: Record<string, any>): Promise<Comment>;
}
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ export default class CustomAudience extends AbstractCrudObject {
deleteUsers(params?: Record<string, any>): Promise<any>;
createUser(fields: string[], params?: Record<string, any>, pathOverride?: string | null): Promise<CustomAudience>;
createUsersReplace(fields: string[], params?: Record<string, any>, pathOverride?: string | null): Promise<CustomAudience>;
get(fields: string[], params?: Record<string, any>): Promise<AbstractObject>;
delete(fields: string[], params?: Record<string, any>): Promise<AbstractObject>;
get(fields: string[], params?: Record<string, any>): Promise<CustomAudience>;
update(fields: string[], params?: Record<string, any>): Promise<CustomAudience>;
}
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ export default class CustomConversion extends AbstractCrudObject {
website: "website";
}>;
getStats(fields: string[], params?: Record<string, any>, fetchFirstPage?: boolean): Cursor | Promise<Cursor>;
get(fields: string[], params?: Record<string, any>): Promise<AbstractObject>;
delete(fields: string[], params?: Record<string, any>): Promise<AbstractObject>;
get(fields: string[], params?: Record<string, any>): Promise<CustomConversion>;
update(fields: string[], params?: Record<string, any>): Promise<CustomConversion>;
}
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ export default class ExtendedCreditAllocationConfig extends AbstractCrudObject {
advertiser: "Advertiser";
agency: "Agency";
}>;
get(fields: string[], params?: Record<string, any>): Promise<AbstractObject>;
delete(fields: string[], params?: Record<string, any>): Promise<AbstractObject>;
get(fields: string[], params?: Record<string, any>): Promise<ExtendedCreditAllocationConfig>;
update(fields: string[], params?: Record<string, any>): Promise<ExtendedCreditAllocationConfig>;
}
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ export default class ExtendedCreditInvoiceGroup extends AbstractCrudObject {
deleteAdAccounts(params?: Record<string, any>): Promise<any>;
getAdAccounts(fields: string[], params?: Record<string, any>, fetchFirstPage?: boolean): Cursor | Promise<Cursor>;
createAdAccount(fields: string[], params?: Record<string, any>, pathOverride?: string | null): Promise<AdAccount>;
get(fields: string[], params?: Record<string, any>): Promise<AbstractObject>;
delete(fields: string[], params?: Record<string, any>): Promise<AbstractObject>;
get(fields: string[], params?: Record<string, any>): Promise<ExtendedCreditInvoiceGroup>;
update(fields: string[], params?: Record<string, any>): Promise<ExtendedCreditInvoiceGroup>;
}
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ export default class HighDemandPeriod extends AbstractCrudObject {
absolute: "ABSOLUTE";
multiplier: "MULTIPLIER";
}>;
get(fields: string[], params?: Record<string, any>): Promise<AbstractObject>;
delete(fields: string[], params?: Record<string, any>): Promise<AbstractObject>;
get(fields: string[], params?: Record<string, any>): Promise<HighDemandPeriod>;
update(fields: string[], params?: Record<string, any>): Promise<HighDemandPeriod>;
}
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ export default class HomeListing extends AbstractCrudObject {
getAugmentedRealitiesMetadata(fields: string[], params?: Record<string, any>, fetchFirstPage?: boolean): Cursor | Promise<Cursor>;
getChannelsToIntegrityStatus(fields: string[], params?: Record<string, any>, fetchFirstPage?: boolean): Cursor | Promise<Cursor>;
getVideosMetadata(fields: string[], params?: Record<string, any>, fetchFirstPage?: boolean): Cursor | Promise<Cursor>;
get(fields: string[], params?: Record<string, any>): Promise<AbstractObject>;
delete(fields: string[], params?: Record<string, any>): Promise<AbstractObject>;
get(fields: string[], params?: Record<string, any>): Promise<HomeListing>;
update(fields: string[], params?: Record<string, any>): Promise<HomeListing>;
}
2 changes: 1 addition & 1 deletion types/facebook-nodejs-business-sdk/src/objects/hotel.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ export default class Hotel extends AbstractCrudObject {
getChannelsToIntegrityStatus(fields: string[], params?: Record<string, any>, fetchFirstPage?: boolean): Cursor | Promise<Cursor>;
getHotelRooms(fields: string[], params?: Record<string, any>, fetchFirstPage?: boolean): Cursor | Promise<Cursor>;
getVideosMetadata(fields: string[], params?: Record<string, any>, fetchFirstPage?: boolean): Cursor | Promise<Cursor>;
get(fields: string[], params?: Record<string, any>): Promise<AbstractObject>;
delete(fields: string[], params?: Record<string, any>): Promise<AbstractObject>;
get(fields: string[], params?: Record<string, any>): Promise<Hotel>;
update(fields: string[], params?: Record<string, any>): Promise<Hotel>;
}
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ export default class IGComment extends AbstractCrudObject {
}>;
getReplies(fields: string[], params?: Record<string, any>, fetchFirstPage?: boolean): Cursor | Promise<Cursor>;
createReply(fields: string[], params?: Record<string, any>, pathOverride?: string | null): Promise<IGComment>;
get(fields: string[], params?: Record<string, any>): Promise<AbstractObject>;
delete(fields: string[], params?: Record<string, any>): Promise<AbstractObject>;
get(fields: string[], params?: Record<string, any>): Promise<IGComment>;
update(fields: string[], params?: Record<string, any>): Promise<IGComment>;
}
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ export default class InstagramComment extends AbstractCrudObject {
}>;
getReplies(fields: string[], params?: Record<string, any>, fetchFirstPage?: boolean): Cursor | Promise<Cursor>;
createReply(fields: string[], params?: Record<string, any>, pathOverride?: string | null): Promise<InstagramComment>;
get(fields: string[], params?: Record<string, any>): Promise<AbstractObject>;
delete(fields: string[], params?: Record<string, any>): Promise<AbstractObject>;
get(fields: string[], params?: Record<string, any>): Promise<InstagramComment>;
update(fields: string[], params?: Record<string, any>): Promise<InstagramComment>;
}
2 changes: 1 addition & 1 deletion types/facebook-nodejs-business-sdk/src/objects/lead.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,6 @@ export default class Lead extends AbstractCrudObject {
retailer_item_id: "retailer_item_id";
vehicle: "vehicle";
}>;
get(fields: string[], params?: Record<string, any>): Promise<AbstractObject>;
delete(fields: string[], params?: Record<string, any>): Promise<AbstractObject>;
get(fields: string[], params?: Record<string, any>): Promise<Lead>;
}
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ export default class LiveVideo extends AbstractCrudObject {
getPolls(fields: string[], params?: Record<string, any>, fetchFirstPage?: boolean): Cursor | Promise<Cursor>;
createPoll(fields: string[], params?: Record<string, any>, pathOverride?: string | null): Promise<VideoPoll>;
getReactions(fields: string[], params?: Record<string, any>, fetchFirstPage?: boolean): Cursor | Promise<Cursor>;
get(fields: string[], params?: Record<string, any>): Promise<AbstractObject>;
delete(fields: string[], params?: Record<string, any>): Promise<AbstractObject>;
get(fields: string[], params?: Record<string, any>): Promise<LiveVideo>;
update(fields: string[], params?: Record<string, any>): Promise<LiveVideo>;
}
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ export default class MediaTitle extends AbstractCrudObject {
getAugmentedRealitiesMetadata(fields: string[], params?: Record<string, any>, fetchFirstPage?: boolean): Cursor | Promise<Cursor>;
getChannelsToIntegrityStatus(fields: string[], params?: Record<string, any>, fetchFirstPage?: boolean): Cursor | Promise<Cursor>;
getVideosMetadata(fields: string[], params?: Record<string, any>, fetchFirstPage?: boolean): Cursor | Promise<Cursor>;
get(fields: string[], params?: Record<string, any>): Promise<AbstractObject>;
delete(fields: string[], params?: Record<string, any>): Promise<AbstractObject>;
get(fields: string[], params?: Record<string, any>): Promise<MediaTitle>;
update(fields: string[], params?: Record<string, any>): Promise<MediaTitle>;
}
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ export default class OpenBridgeConfiguration extends AbstractCrudObject {
instance_id: "instance_id";
pixel_id: "pixel_id";
}>;
get(fields: string[], params?: Record<string, any>): Promise<AbstractObject>;
delete(fields: string[], params?: Record<string, any>): Promise<AbstractObject>;
get(fields: string[], params?: Record<string, any>): Promise<OpenBridgeConfiguration>;
update(fields: string[], params?: Record<string, any>): Promise<OpenBridgeConfiguration>;
}
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ export default class PageCallToAction extends AbstractCrudObject {
shop_on_facebook: "SHOP_ON_FACEBOOK";
website: "WEBSITE";
}>;
get(fields: string[], params?: Record<string, any>): Promise<AbstractObject>;
delete(fields: string[], params?: Record<string, any>): Promise<AbstractObject>;
get(fields: string[], params?: Record<string, any>): Promise<PageCallToAction>;
update(fields: string[], params?: Record<string, any>): Promise<PageCallToAction>;
}
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,6 @@ export default class PagePostExperiment extends AbstractCrudObject {
video_views_60s: "VIDEO_VIEWS_60S";
}>;
getVideoInsights(fields: string[], params?: Record<string, any>, fetchFirstPage?: boolean): Cursor | Promise<Cursor>;
get(fields: string[], params?: Record<string, any>): Promise<AbstractObject>;
delete(fields: string[], params?: Record<string, any>): Promise<AbstractObject>;
get(fields: string[], params?: Record<string, any>): Promise<PagePostExperiment>;
}
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ export default class PagePost extends AbstractCrudObject {
getShareDPosts(fields: string[], params?: Record<string, any>, fetchFirstPage?: boolean): Cursor | Promise<Cursor>;
getSponsorTags(fields: string[], params?: Record<string, any>, fetchFirstPage?: boolean): Cursor | Promise<Cursor>;
getTo(fields: string[], params?: Record<string, any>, fetchFirstPage?: boolean): Cursor | Promise<Cursor>;
get(fields: string[], params?: Record<string, any>): Promise<AbstractObject>;
delete(fields: string[], params?: Record<string, any>): Promise<AbstractObject>;
get(fields: string[], params?: Record<string, any>): Promise<PagePost>;
update(fields: string[], params?: Record<string, any>): Promise<PagePost>;
}
Loading

0 comments on commit db345b9

Please sign in to comment.