🤖 Merge PR DefinitelyTyped#69535 [@types/node] Make it possible to us…

…e `static EventEmitter.on` with `EventTarget` by @sgrishchenko
jessejay-ch · Jun 5, 2024 · dc1b21c · dc1b21c
1 parent 701884e
commit dc1b21c
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 0 deletions.
diff --git a/types/node/events.d.ts b/types/node/events.d.ts
@@ -280,6 +280,11 @@ declare module "events" {
          */
         static on(
             emitter: NodeJS.EventEmitter,
+            eventName: string | symbol,
+            options?: StaticEventEmitterOptions,
+        ): AsyncIterableIterator<any>;
+        static on(
+            emitter: EventTarget,
             eventName: string,
             options?: StaticEventEmitterOptions,
         ): AsyncIterableIterator<any>;

diff --git a/types/node/test/events.ts b/types/node/test/events.ts
@@ -102,6 +102,20 @@ async function test() {
     events.on(new events.EventEmitter(), "test", { signal: new AbortController().signal });
 }
 
+async function testWithSymbol() {
+    for await (const e of events.on(new events.EventEmitter(), Symbol("test"))) {
+        console.log(e);
+    }
+    events.on(new events.EventEmitter(), Symbol("test"), { signal: new AbortController().signal });
+}
+
+async function testEventTarget() {
+    for await (const e of events.on(new EventTarget(), "test")) {
+        console.log(e);
+    }
+    events.on(new EventTarget(), "test", { signal: new AbortController().signal });
+}
+
 {
     emitter.on(events.errorMonitor, listener);
     emitter.on(events.EventEmitter.errorMonitor, listener);