forked from github/codeql
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request github#18454 from owen-mc/go/mad/encoding-and-weak
Go: Add models for standard library updates in Go 1.24
- Loading branch information
Showing
8 changed files
with
130 additions
and
36 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| category: minorAnalysis | ||
| --- | ||
| * Taint models have been added for the `weak` package, which was added in Go 1.24. | ||
| * Taint models have been added for the interfaces `TextAppender` and `BinaryAppender` in the `encoding` package, which were added in Go 1.24. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| extensions: | ||
| - addsTo: | ||
| pack: codeql/go-all | ||
| extensible: summaryModel | ||
| data: | ||
| - ["weak", "", False, "Make", "", "", "Argument[0]", "ReturnValue[0]", "taint", "manual"] | ||
| - ["weak", "Pointer", False, "Value", "", "", "Argument[receiver]", "ReturnValue[0]", "taint", "manual"] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 2 additions & 1 deletion
3
go/ql/test/library-tests/semmle/go/frameworks/BeegoOrm/StoredXss.qlref
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,2 @@ | ||
| Security/CWE-079/StoredXss.ql | ||
| query: Security/CWE-079/StoredXss.ql | ||
| postprocess: utils/test/PrettyPrintModels.ql |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
27 changes: 27 additions & 0 deletions
27
go/ql/test/library-tests/semmle/go/frameworks/StdlibTaintFlow/Weak.go
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| package main | ||
|
|
||
| import "weak" | ||
|
|
||
| func TaintStepTest_WeakMake_manual(sourceCQL interface{}) interface{} { | ||
| fromStringPointer := sourceCQL.(*string) | ||
| intoWeakPointer := weak.Make(fromStringPointer) | ||
| return intoWeakPointer | ||
| } | ||
| func TaintStepTest_WeakValue_manual(sourceCQL interface{}) interface{} { | ||
| fromWeakPointer := sourceCQL.(weak.Pointer[string]) | ||
| intoStringPointer := fromWeakPointer.Value() | ||
| return intoStringPointer | ||
| } | ||
|
|
||
| func RunAllTaints_Weak() { | ||
| { | ||
| source := newSource(0) | ||
| out := TaintStepTest_WeakMake_manual(source) | ||
| sink(0, out) | ||
| } | ||
| { | ||
| source := newSource(1) | ||
| out := TaintStepTest_WeakValue_manual(source) | ||
| sink(1, out) | ||
| } | ||
| } |
2 changes: 1 addition & 1 deletion
2
go/ql/test/library-tests/semmle/go/frameworks/StdlibTaintFlow/go.mod
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| module example.com/m | ||
|
|
||
| go 1.23 | ||
| go 1.24 | ||
|
|
||
| require ( | ||
| golang.org/x/net v0.0.0-20201010224723-4f7140c49acb | ||
|
|
||