-
Notifications
You must be signed in to change notification settings - Fork 25
VC-39644 Collect info for the venafiConnection and more issuers #648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR extends the Kubernetes agent's resource collection capabilities to support additional issuers and the Venafi connection.
- Adds new RBAC definitions for Venafi Connection, Smallstep Issuer, Cloudflare Origin CA, FreeIPA Issuer, and EJBCA Issuer.
- Updates the configuration map to include dynamic resource configurations for the newly supported resources.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
File | Description |
---|---|
deploy/charts/venafi-kubernetes-agent/templates/rbac.yaml | New ClusterRoles and ClusterRoleBindings for managing access to the various resource types. |
deploy/charts/venafi-kubernetes-agent/templates/configmap.yaml | Added k8s-dynamic resource definitions for Venafi Connection, Smallstep Issuer, Cloudflare Origin CA, FreeIPA Issuer, and EJBCA Issuer. |
Comments suppressed due to low confidence (2)
deploy/charts/venafi-kubernetes-agent/templates/rbac.yaml:433
- [nitpick] The name 'keyfactor-reader' might be confusing given that the group is 'ejbca-issuer.keyfactor.com'. Consider renaming it to 'ejbca-reader' for clarity, if that accurately reflects its purpose.
name: {{ include "venafi-kubernetes-agent.fullname" . }}-keyfactor-reader
deploy/charts/venafi-kubernetes-agent/templates/configmap.yaml:261
- [nitpick] Consider using a consistent naming convention by adding a hyphen (e.g., 'k8s/freeipa-issuers') to align with the naming patterns used for the other issuer resources.
name: "k8s/freeipaissuers"
I ran the E2E test script (it has to be run manually for the time being. Everything seemed to work fine. Here's some of the output:
|
This PR updates the Kubernetes agent by extending its resource collection capabilities. The newly supported resources include: