Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XRAY-102173 - Better support 7z #25

Merged
merged 1 commit into from
Feb 9, 2025
Merged

XRAY-102173 - Better support 7z #25

merged 1 commit into from
Feb 9, 2025

Conversation

slavikp1976
Copy link
Collaborator

No description provided.

@slavikp1976 slavikp1976 force-pushed the XRAY-102173-support-7z-new-form branch from 4b57d5f to 81507eb Compare February 6, 2025 09:53
orz25
orz25 reviewed Feb 6, 2025
View reviewed changes
archive_extractor/archiver_errors/open_error.go Outdated
return fmt.Sprintf("Failed to open file, file:%s, err:%s", op.msg, op.err.Error())
}

func (op *OpenError) Unwrap() error {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can remove this function. You are not using it and it's not part of error interface

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which Unwrap?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need Unwrap for support errors.As

Copy link
Collaborator

@orz25 orz25 Feb 6, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh ok. Got you

@slavikp1976 slavikp1976 force-pushed the XRAY-102173-support-7z-new-form branch from 81507eb to 145a21c Compare February 6, 2025 11:27
@slavikp1976 slavikp1976 force-pushed the XRAY-102173-support-7z-new-form branch 5 times, most recently from fbc3050 to 8d73466 Compare February 6, 2025 19:27
@slavikp1976 slavikp1976 force-pushed the XRAY-102173-support-7z-new-form branch from 8d73466 to 4695b74 Compare February 9, 2025 09:22
@slavikp1976 slavikp1976 merged commit 58e143b into master Feb 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orz25 orz25 orz25 approved these changes

@maoreitan maoreitan Awaiting requested review from maoreitan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slavikp1976 @orz25