Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sets Intersection and Union Operations #49

Closed
wants to merge 4 commits into from
Closed

Add Sets Intersection and Union Operations #49

wants to merge 4 commits into from

Conversation

noyshabtay
Copy link
Contributor

@noyshabtay noyshabtay commented Jan 30, 2024

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.
  • I labeled this pull request with one of the following: 'breaking change', 'new feature', 'bug', or 'ignore for release'

In the Gofrog package, sets data structures are exposed due to the absence of built-in sets in the Go language. This pull request introduces classic sets operations to our implementation, facilitating union and intersection between sets.

sverdlov93 and others added 2 commits January 22, 2024 16:39
* update deps

* union and intersection operations added to sets

* tests were added

---------

Co-authored-by: Michael Sverdlov <[email protected]>
Co-authored-by: Michael Sverdlov <[email protected]>
@noyshabtay noyshabtay added the new feature Automatically generated release notes label Jan 30, 2024
@noyshabtay noyshabtay requested a review from omerzi January 30, 2024 15:51
@noyshabtay noyshabtay self-assigned this Jan 30, 2024
@noyshabtay noyshabtay requested a review from sverdlov93 January 30, 2024 15:54
Copy link

👍 Frogbot scanned this pull request and found that it did not add vulnerable dependencies.


noyshabtay and others added 2 commits January 30, 2024 22:54
* update deps

* union and intersection operations added to sets

* tests were added

---------

Co-authored-by: Michael Sverdlov <[email protected]>
Co-authored-by: Michael Sverdlov <[email protected]>
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@noyshabtay noyshabtay changed the title Dev Add Sets Intersection and Union Operations Jan 31, 2024
@sverdlov93
Copy link
Contributor

also, you should create a new brunch with your feature and then create a PR to dev, and not commit directly to dev

@noyshabtay noyshabtay closed this Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature Automatically generated release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants