Skip to content

RTECO-1074 - Remove redundendent functions in agent namespace(1/2)#495

Open
udaykb2 wants to merge 2 commits into
mainfrom
RTECO-1074-Remove-agent-redundent-functions-1
Open

RTECO-1074 - Remove redundendent functions in agent namespace(1/2)#495
udaykb2 wants to merge 2 commits into
mainfrom
RTECO-1074-Remove-agent-redundent-functions-1

Conversation

@udaykb2

@udaykb2 udaykb2 commented Jun 18, 2026

Copy link
Copy Markdown
Contributor
  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • Appropriate label is added to auto generate release notes.
  • I used gofmt for formatting the code before submitting the pull request.
  • PR description is clear and concise, and it includes the proposed solution/fix.

Summary

Removes wrapper functions that were duplicating logic between agent/plugins/common and agent/skills/common. Specifically:

  • Moved ResolveAgentTargets, CopyExtractedToTargets, and related helpers up to agent/common (the single source of truth)
  • Deleted the per-namespace copies in plugins/common and skills/common
  • Updated all callers in install.go, update.go, list.go to call agentcommon.* directly
  • Moved tests to agent/common

@udaykb2 udaykb2 added the improvement Automatically generated release notes label Jun 19, 2026
@udaykb2 udaykb2 changed the title Remove redundendent functions in agent namespace(1/2) RTECO-1074 - Remove redundendent functions in agent namespace(1/2) Jun 19, 2026
@udaykb2 udaykb2 added the safe to test Approve running integration tests on a pull request label Jun 19, 2026
@github-actions github-actions Bot removed the safe to test Approve running integration tests on a pull request label Jun 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Automatically generated release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant